netdev - Re: [PATCH net-next 3/3] net/mlx5: Remove unused msix related exported APIs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAH-L+nPOW8_miPvwkv7rEzWRsnVy3Q+-rd8FyWo6-HnBwBJKxQ@mail.gmail.com>
Date: Mon, 13 May 2024 14:44:53 +0530
From: Kalesh Anakkur Purayil <kalesh-anakkur.purayil@...adcom.com>
To: Tariq Toukan <tariqt@...dia.com>
Cc: "David S. Miller" <davem@...emloft.net>, Jakub Kicinski <kuba@...nel.org>, 
	Paolo Abeni <pabeni@...hat.com>, Eric Dumazet <edumazet@...gle.com>, netdev@...r.kernel.org, 
	Saeed Mahameed <saeedm@...dia.com>, Gal Pressman <gal@...dia.com>, Leon Romanovsky <leonro@...dia.com>, 
	Parav Pandit <parav@...dia.com>, Dragos Tatulea <dtatulea@...dia.com>
Subject: Re: [PATCH net-next 3/3] net/mlx5: Remove unused msix related
 exported APIs

On Sun, May 12, 2024 at 6:14 PM Tariq Toukan <tariqt@...dia.com> wrote:
>
> From: Parav Pandit <parav@...dia.com>
>
> MSIX irq allocation and free APIs are no longer
> in use. Hence, remove the dead code.
>
> Signed-off-by: Parav Pandit <parav@...dia.com>
> Reviewed-by: Dragos Tatulea <dtatulea@...dia.com>
> Signed-off-by: Tariq Toukan <tariqt@...dia.com>

Looks good to me.

Reviewed-by: Kalesh AP <kalesh-anakkur.purayil@...adcom.com>
> ---
>  .../net/ethernet/mellanox/mlx5/core/pci_irq.c | 52 -------------------
>  include/linux/mlx5/driver.h                   |  7 ---
>  2 files changed, 59 deletions(-)
>
> diff --git a/drivers/net/ethernet/mellanox/mlx5/core/pci_irq.c b/drivers/net/ethernet/mellanox/mlx5/core/pci_irq.c
> index 6bac8ad70ba6..fb8787e30d3f 100644
> --- a/drivers/net/ethernet/mellanox/mlx5/core/pci_irq.c
> +++ b/drivers/net/ethernet/mellanox/mlx5/core/pci_irq.c
> @@ -507,58 +507,6 @@ struct mlx5_irq *mlx5_irq_request(struct mlx5_core_dev *dev, u16 vecidx,
>         return irq;
>  }
>
> -/**
> - * mlx5_msix_alloc - allocate msix interrupt
> - * @dev: mlx5 device from which to request
> - * @handler: interrupt handler
> - * @affdesc: affinity descriptor
> - * @name: interrupt name
> - *
> - * Returns: struct msi_map with result encoded.
> - * Note: the caller must make sure to release the irq by calling
> - *       mlx5_msix_free() if shutdown was initiated.
> - */
> -struct msi_map mlx5_msix_alloc(struct mlx5_core_dev *dev,
> -                              irqreturn_t (*handler)(int, void *),
> -                              const struct irq_affinity_desc *affdesc,
> -                              const char *name)
> -{
> -       struct msi_map map;
> -       int err;
> -
> -       if (!dev->pdev) {
> -               map.virq = 0;
> -               map.index = -EINVAL;
> -               return map;
> -       }
> -
> -       map = pci_msix_alloc_irq_at(dev->pdev, MSI_ANY_INDEX, affdesc);
> -       if (!map.virq)
> -               return map;
> -
> -       err = request_irq(map.virq, handler, 0, name, NULL);
> -       if (err) {
> -               mlx5_core_warn(dev, "err %d\n", err);
> -               pci_msix_free_irq(dev->pdev, map);
> -               map.virq = 0;
> -               map.index = -ENOMEM;
> -       }
> -       return map;
> -}
> -EXPORT_SYMBOL(mlx5_msix_alloc);
> -
> -/**
> - * mlx5_msix_free - free a previously allocated msix interrupt
> - * @dev: mlx5 device associated with interrupt
> - * @map: map previously returned by mlx5_msix_alloc()
> - */
> -void mlx5_msix_free(struct mlx5_core_dev *dev, struct msi_map map)
> -{
> -       free_irq(map.virq, NULL);
> -       pci_msix_free_irq(dev->pdev, map);
> -}
> -EXPORT_SYMBOL(mlx5_msix_free);
> -
>  /**
>   * mlx5_irq_release_vector - release one IRQ back to the system.
>   * @irq: the irq to release.
> diff --git a/include/linux/mlx5/driver.h b/include/linux/mlx5/driver.h
> index 8218588688b5..0aa15cac0308 100644
> --- a/include/linux/mlx5/driver.h
> +++ b/include/linux/mlx5/driver.h
> @@ -1374,11 +1374,4 @@ static inline bool mlx5_is_macsec_roce_supported(struct mlx5_core_dev *mdev)
>  enum {
>         MLX5_OCTWORD = 16,
>  };
> -
> -struct msi_map mlx5_msix_alloc(struct mlx5_core_dev *dev,
> -                              irqreturn_t (*handler)(int, void *),
> -                              const struct irq_affinity_desc *affdesc,
> -                              const char *name);
> -void mlx5_msix_free(struct mlx5_core_dev *dev, struct msi_map map);
> -
>  #endif /* MLX5_DRIVER_H */
> --
> 2.44.0
>
>


-- 
Regards,
Kalesh A P

Download attachment "smime.p7s" of type "application/pkcs7-signature" (4239 bytes)