netdev - Re: [PATCH AUTOSEL 5.10 5/9] net: qede: sanitize 'rc' in qede_add_tc_flower

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ea7ae0c4-a582-42ce-9bc9-5f3df1915ca0@fiberby.net>
Date: Mon, 13 May 2024 09:46:02 +0000
From: Asbjørn Sloth Tønnesen <ast@...erby.net>
To: Pavel Machek <pavel@...x.de>, Sasha Levin <sashal@...nel.org>
Cc: linux-kernel@...r.kernel.org, stable@...r.kernel.org,
 Simon Horman <horms@...nel.org>, "David S . Miller" <davem@...emloft.net>,
 manishc@...vell.com, edumazet@...gle.com, kuba@...nel.org,
 pabeni@...hat.com, netdev@...r.kernel.org
Subject: Re: [PATCH AUTOSEL 5.10 5/9] net: qede: sanitize 'rc' in
 qede_add_tc_flower_fltr()

Hi Pavel and Sasha,

On 5/13/24 8:18 AM, Pavel Machek wrote:
>> Explicitly set 'rc' (return code), before jumping to the
>> unlock and return path.
>>
>> By not having any code depend on that 'rc' remains at
>> it's initial value of -EINVAL, then we can re-use 'rc' for
>> the return code of function calls in subsequent patches.
>>
>> Only compile tested.
> 
> Only compile tested, and is a preparation for something we won't do in
> stable. Does not fix a bug, please drop.

Please see the original thread about this series[1], this patch is a requirement for
two of the next patches, which does fix a few bugs with overruled error codes returned
to user space.

I was originally going to ignore these AUTOSEL mails, since the whole series was already
added to the queued more than 24 hours earlier[2]. In the queue Sasha has also added "Stable-dep-of:'.

So the weird thing is that AUTOSEL selected this patch, given that it was already in the queue.

[1] https://lore.kernel.org/netdev/20240426091227.78060-1-ast@fiberby.net/
[2] https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git/log/?h=queue/5.10

-- 
Best regards
Asbjørn Sloth Tønnesen
Network Engineer
Fiberby - AS42541