netdev - Re: [PATCH net-next v12 04/15] net: stmmac: dwmac-loongson: Drop useless platform data

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87557791-ca0e-48e6-a47f-1247fbba4c85@loongson.cn>
Date: Mon, 13 May 2024 17:47:53 +0800
From: Yanteng Si <siyanteng@...ngson.cn>
To: Serge Semin <fancer.lancer@...il.com>
Cc: andrew@...n.ch, hkallweit1@...il.com, peppe.cavallaro@...com,
 alexandre.torgue@...s.st.com, joabreu@...opsys.com, Jose.Abreu@...opsys.com,
 chenhuacai@...nel.org, linux@...linux.org.uk, guyinggang@...ngson.cn,
 netdev@...r.kernel.org, chris.chenfeiyang@...il.com, siyanteng01@...il.com
Subject: Re: [PATCH net-next v12 04/15] net: stmmac: dwmac-loongson: Drop
 useless platform data


在 2024/5/3 22:47, Serge Semin 写道:
> On Fri, May 03, 2024 at 01:55:38PM +0300, Serge Semin wrote:
>> On Thu, Apr 25, 2024 at 09:04:35PM +0800, Yanteng Si wrote:
>>> The multicast_filter_bins is initialized twice, it should
>>> be 256, let's drop the first useless assignment.
>> Please drop the second plat_stmmacenet_data::multicast_filter_bins
>> init statement and just change the first one to initializing the
>> correct value - 256. Thus you'll have
>> 1. the multicast and unicast filters size inits done in the same place;
>> 2. the in-situ comments preserved (it's not like they're that much
>> helpful, but seeing the rest of the lines have a comment above it
>> would be nice to have the comment preserved here too);
>> 3. dropped the statement closely attached to the return statement
>> (in kernel it's a widespread practice to separate the return
>> statement with an empty line).
>>
>> The unit 1. is the main reason of course.
>>
>> A bit more readable commit log would be:
>>
>> "The plat_stmmacenet_data::multicast_filter_bins  field is twice
>> initialized in the loongson_default_data() method. Drop the redundant
>> initialization, but for the readability sake keep the filters init
>> statements defined in the same place of the method."
> [PATCH net-next v12 04/15] net: stmmac: dwmac-loongson: Drop useless platform data
>
> The patch subject is too generic. Just make it:
>
> [PATCH net-next v12 04/15] net: stmmac: dwmac-loongson: Drop duplicated hash-based filter size init

OK, Thanks!


Thanks,

Yanteng