netdev - Re: [PATCH net-next v12 05/15] net: stmmac: dwmac-loongson: Use PCI_DEVICE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <0dba2790-3885-47eb-85a1-d8b7a1c382ac@loongson.cn>
Date: Mon, 13 May 2024 17:50:07 +0800
From: Yanteng Si <siyanteng@...ngson.cn>
To: Serge Semin <fancer.lancer@...il.com>
Cc: andrew@...n.ch, hkallweit1@...il.com, peppe.cavallaro@...com,
 alexandre.torgue@...s.st.com, joabreu@...opsys.com, Jose.Abreu@...opsys.com,
 chenhuacai@...nel.org, linux@...linux.org.uk, guyinggang@...ngson.cn,
 netdev@...r.kernel.org, chris.chenfeiyang@...il.com, siyanteng01@...il.com
Subject: Re: [PATCH net-next v12 05/15] net: stmmac: dwmac-loongson: Use
 PCI_DEVICE_DATA() macro for device identification


在 2024/5/3 21:43, Serge Semin 写道:
> On Thu, Apr 25, 2024 at 09:04:36PM +0800, Yanteng Si wrote:
>> Just use PCI_DEVICE_DATA() macro for device identification,
>> No changes to function functionality.
> Some more verbose commit log:
>
> "For the readability sake convert the hard-coded Loongson GMAC PCI ID to
> the respective macro and use the PCI_DEVICE_DATA() macro-function to
> create the pci_device_id array entry. The later change will be
> specifically useful in order to assign the device-specific data for the
> currently supported device and for about to be added Loongson GNET
> controller."
>
> Other than that the change looks good:
>
> Reviewed-by: Serge Semin<fancer.lancer@...il.com>

OK, Thanks!


Thanks,

Yanteng