netdev - Re: [PATCH net-next v12 08/15] net: stmmac: dwmac-loongson: Add phy mask for Loongson GMAC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <02e83207-d2a9-4057-8205-4954f34cc3ec@loongson.cn>
Date: Mon, 13 May 2024 18:23:23 +0800
From: Yanteng Si <siyanteng@...ngson.cn>
To: Serge Semin <fancer.lancer@...il.com>
Cc: andrew@...n.ch, hkallweit1@...il.com, peppe.cavallaro@...com,
 alexandre.torgue@...s.st.com, joabreu@...opsys.com, Jose.Abreu@...opsys.com,
 chenhuacai@...nel.org, linux@...linux.org.uk, guyinggang@...ngson.cn,
 netdev@...r.kernel.org, chris.chenfeiyang@...il.com, siyanteng01@...il.com
Subject: Re: [PATCH net-next v12 08/15] net: stmmac: dwmac-loongson: Add phy
 mask for Loongson GMAC


在 2024/5/4 02:28, Serge Semin 写道:
> On Thu, Apr 25, 2024 at 09:06:11PM +0800, Yanteng Si wrote:
>> The phy mask of gmac(and gnet) is 0.
> First of all the GNET PHY mask won't be zero as you setting it up to
> ~BIT(2) in the patch 13 yourself. Secondly the stmmac_mdio_bus_data
> structure instance is Z-malloced, thus it will be zeroed anyway. So
> the only reason why the explicit stmmac_mdio_bus_data::phy_mask
> zeroing would be useful is to signify the difference between the GMAC
> and GNET devices. But that difference could be relatively easy
> inferred from the code. So to speak IMO the patch has a little value.
> I would drop it.

OK, drop it.


Thanks,

Yanteng