netdev - Re: [PATCH net] net: mhi: set skb mac header before entering RX path

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20240513163844.402a926d@kernel.org>
Date: Mon, 13 May 2024 16:38:44 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Martin Fäcknitz <faecknitz@...splots.de>
Cc: netdev@...r.kernel.org
Subject: Re: [PATCH net] net: mhi: set skb mac header before entering RX
 path

On Mon, 13 May 2024 15:38:30 +0200 Martin Fäcknitz wrote:
> skb->mac_header must be set before passing the skb to the network stack,
> because skb->mac_len is calculated from skb->mac_header in
> __netif_receive_skb_core.
> 
> Some network stack components, like xfrm, are using skb->mac_len to
> check for an existing MAC header, which doesn't exist in this case. This
> leads to memory corruption.

Could you add a Fixes tag identifying the commit where the buggy code
was added? And please make sure to CC the relevant maintainers (I mean
the maintainers of the MHI code, specifically) on v2.
-- 
pw-bot: cr