netdev - [PATCH 1/2] net: phy: dp83869: Add PHY ID for chip revision 3

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <20240514122728.1490156-1-thomas.gessler@brueckmann-gmbh.de>
Date: Tue, 14 May 2024 14:27:27 +0200
From: Thomas Gessler <thomas.gessler@...eckmann-gmbh.de>
To: Andrew Lunn <andrew@...n.ch>,
	Heiner Kallweit <hkallweit1@...il.com>,
	Russell King <linux@...linux.org.uk>,
	"David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>,
	Paolo Abeni <pabeni@...hat.com>
Cc: netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org,
	Thomas Gessler <thomas.gessler@...eckmann-gmbh.de>,
	MD Danish Anwar <danishanwar@...com>,
	Ravi Gunasekaran <r-gunasekaran@...com>
Subject: [PATCH 1/2] net: phy: dp83869: Add PHY ID for chip revision 3

The recent silicon revision 3 of the DP83869 has a different PHY ID
which has to be added to the driver in order for the PHY to be detected.
There appear to be no documented differences between the revisions,
although there are some discussions in the TI forum about different
behavior for some registers.

Signed-off-by: Thomas Gessler <thomas.gessler@...eckmann-gmbh.de>
---
 drivers/net/phy/dp83869.c | 9 ++++++---
 1 file changed, 6 insertions(+), 3 deletions(-)

diff --git a/drivers/net/phy/dp83869.c b/drivers/net/phy/dp83869.c
index d7aaefb5226b..d248a13c1749 100644
--- a/drivers/net/phy/dp83869.c
+++ b/drivers/net/phy/dp83869.c
@@ -15,7 +15,8 @@
 
 #include <dt-bindings/net/ti-dp83869.h>
 
-#define DP83869_PHY_ID		0x2000a0f1
+#define DP83869REV1_PHY_ID	0x2000a0f1
+#define DP83869REV3_PHY_ID	0x2000a0f3
 #define DP83561_PHY_ID		0x2000a1a4
 #define DP83869_DEVADDR		0x1f
 
@@ -909,14 +910,16 @@ static int dp83869_phy_reset(struct phy_device *phydev)
 }
 
 static struct phy_driver dp83869_driver[] = {
-	DP83869_PHY_DRIVER(DP83869_PHY_ID, "TI DP83869"),
+	DP83869_PHY_DRIVER(DP83869REV1_PHY_ID, "TI DP83869 Rev. 1"),
+	DP83869_PHY_DRIVER(DP83869REV3_PHY_ID, "TI DP83869 Rev. 3"),
 	DP83869_PHY_DRIVER(DP83561_PHY_ID, "TI DP83561-SP"),
 
 };
 module_phy_driver(dp83869_driver);
 
 static struct mdio_device_id __maybe_unused dp83869_tbl[] = {
-	{ PHY_ID_MATCH_MODEL(DP83869_PHY_ID) },
+	{ PHY_ID_MATCH_MODEL(DP83869REV1_PHY_ID) },
+	{ PHY_ID_MATCH_MODEL(DP83869REV3_PHY_ID) },
 	{ PHY_ID_MATCH_MODEL(DP83561_PHY_ID) },
 	{ }
 };
-- 
2.34.1