netdev - Re: [PATCH wireless-next] ath11k: Fix error path in ath11k_pcic_ext_irq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <171569306687.2017278.16792087877494747045.kvalo@kernel.org>
Date: Tue, 14 May 2024 13:24:28 +0000 (UTC)
From: Kalle Valo <kvalo@...nel.org>
To: Breno Leitao <leitao@...ian.org>
Cc: horms@...nel.org, Jeff Johnson <jjohnson@...nel.org>,
 "David S. Miller" <davem@...emloft.net>, netdev@...r.kernel.org,
 linux-wireless@...r.kernel.org (open list:NETWORKING DRIVERS (WIRELESS)),
 ath11k@...ts.infradead.org (open list:QUALCOMM ATHEROS ATH11K WIRELESS
 DRIVER), linux-kernel@...r.kernel.org (open list)
Subject: Re: [PATCH wireless-next] ath11k: Fix error path in
 ath11k_pcic_ext_irq_config

Breno Leitao <leitao@...ian.org> wrote:

> If one of the dummy allocation fails in ath11k_pcic_ext_irq_config(),
> the previous allocated devices might leak due to returning without
> deallocating the devices.
> 
> Instead of returning on the error path, deallocate all the previously
> allocated net_devices and then return.
> 
> Fixes: bca592ead825 ("wifi: ath11k: allocate dummy net_device dynamically")
> Signed-off-by: Breno Leitao <leitao@...ian.org>
> Reviewed-by: Simon Horman <horms@...nel.org>

As commit bca592ead825 is in net-next I think this patch needs to go to v6.10, right?

-- 
https://patchwork.kernel.org/project/linux-wireless/patch/20240508185902.70975-1-leitao@debian.org/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches