netdev - Re: [PATCH] net: qrtr: ns: Fix module refcnt

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <7985e7d7-e96c-0657-7a56-973d0b802d59@quicinc.com>
Date: Tue, 14 May 2024 09:05:19 -0600
From: Jeffrey Hugo <quic_jhugo@...cinc.com>
To: Chris Lew <quic_clew@...cinc.com>,
        Manivannan Sadhasivam
	<manivannan.sadhasivam@...aro.org>,
        "David S. Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>,
        "Paolo
 Abeni" <pabeni@...hat.com>,
        Bjorn Andersson <andersson@...nel.org>, Luca
 Weiss <luca@...tu.xyz>
CC: Manivannan Sadhasivam <mani@...nel.org>, <linux-arm-msm@...r.kernel.org>,
        <netdev@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] net: qrtr: ns: Fix module refcnt

On 5/13/2024 11:31 AM, Chris Lew wrote:
> The qrtr protocol core logic and the qrtr nameservice are combined into
> a single module. Neither the core logic or nameservice provide much
> functionality by themselves; combining the two into a single module also
> prevents any possible issues that may stem from client modules loading
> inbetween qrtr and the ns.
> 
> Creating a socket takes two references to the module that owns the
> socket protocol. Since the ns needs to create the control socket, this
> creates a scenario where there are always two references to the qrtr
> module. This prevents the execution of 'rmmod' for qrtr.
> 
> To resolve this, forcefully put the module refcount for the socket
> opened by the nameservice.
> 
> Fixes: a365023a76f2 ("net: qrtr: combine nameservice into main module")
> Reported-by: Jeffrey Hugo <quic_jhugo@...cinc.com>
> Tested-by: Jeffrey Hugo <quic_jhugo@...cinc.com>
> Signed-off-by: Chris Lew <quic_clew@...cinc.com>

Reviewed-by: Jeffrey Hugo <quic_jhugo@...cinc.com>