netdev - Re: [PATCH net-next v3 5/5] net: ethernet: cortina: Implement .set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CACRpkdanJ+qaJNLEfSuOe6ricjOQ9+KyRdbYueK176ASh0t6BQ@mail.gmail.com>
Date: Tue, 14 May 2024 23:13:43 +0200
From: Linus Walleij <linus.walleij@...aro.org>
To: Andrew Lunn <andrew@...n.ch>
Cc: Hans Ulli Kroll <ulli.kroll@...glemail.com>, "David S. Miller" <davem@...emloft.net>, 
	Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, 
	netdev@...r.kernel.org
Subject: Re: [PATCH net-next v3 5/5] net: ethernet: cortina: Implement .set_pauseparam()

On Tue, May 14, 2024 at 4:32 PM Andrew Lunn <andrew@...n.ch> wrote:
> On Tue, May 14, 2024 at 10:55:18AM +0200, Linus Walleij wrote:

> > I don't know if I don't understand the flow of code here...
> >
> > The Datasheet says that these registers shall be programmed to
> > match what is set up in the PHY.
>
> I expect the registers should match what the PHY has negotiated, not
> what it is advertising. So i would expect to see
> gmac_set_flow_control() only in the adjust link callback once
> negotiation has completed.

I get it, you are right of course. I'll send a new iteration dropping
this setting after net-next opens again in two weeks. (also split
off these three patches separately.)

Yours,
Linus Walleij