[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20240514024202.10366-1-kuniyu@amazon.com>
Date: Tue, 14 May 2024 11:42:02 +0900
From: Kuniyuki Iwashima <kuniyu@...zon.com>
To: <horms@...nel.org>
CC: <billy@...rlabs.sg>, <davem@...emloft.net>, <edumazet@...gle.com>,
<kuba@...nel.org>, <kuni1840@...il.com>, <kuniyu@...zon.com>, <mhal@...x.co>,
<netdev@...r.kernel.org>, <pabeni@...hat.com>
Subject: Re: [PATCH v3 net] af_unix: Update unix_sk(sk)->oob_skb under sk_receive_queue lock.
From: Simon Horman <horms@...nel.org>
Date: Mon, 13 May 2024 17:57:47 +0100
> On Mon, May 13, 2024 at 10:06:28PM +0900, Kuniyuki Iwashima wrote:
>
> ...
>
> > @@ -2666,13 +2681,19 @@ static struct sk_buff *manage_oob(struct sk_buff *skb, struct sock *sk,
> > } else if (flags & MSG_PEEK) {
> > skb = NULL;
> > } else {
> > - skb_unlink(skb, &sk->sk_receive_queue);
> > + __skb_unlink(skb, &sk->sk_receive_queue);
> > WRITE_ONCE(u->oob_skb, NULL);
> > - if (!WARN_ON_ONCE(skb_unref(skb)))
> > - kfree_skb(skb);
> > + unlinked_skb = skb;
> > skb = skb_peek(&sk->sk_receive_queue);
> > }
> > }
> > +
> > + spin_unlock(&sk->sk_receive_queue.lock);
> > +
> > + if (unlinked_skb) {
> > + WARN_ON_ONCE(skb_unref(skb));
> > + kfree_skb(skb);
>
> Hi Iwashima-san,
>
> Here skb is kfree'd.
Ah, I apparently made a typo...
Will fix in v4, thanks!
Powered by blists - more mailing lists