netdev - Re: [PATCH] octeontx2-pf: devlink params support to set TL1 round robin priority

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: 
 <PH0PR18MB44744704A95A0BAD5AD05856DEE32@PH0PR18MB4474.namprd18.prod.outlook.com>
Date: Tue, 14 May 2024 07:54:10 +0000
From: Hariprasad Kelam <hkelam@...vell.com>
To: Jakub Kicinski <kuba@...nel.org>
CC: "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "davem@...emloft.net" <davem@...emloft.net>,
        Sunil Kovvuri Goutham
	<sgoutham@...vell.com>,
        Geethasowjanya Akula <gakula@...vell.com>,
        Jerin
 Jacob <jerinj@...vell.com>, Linu Cherian <lcherian@...vell.com>,
        Subbaraya
 Sundeep Bhatta <sbhatta@...vell.com>,
        Naveen Mamindlapalli
	<naveenm@...vell.com>,
        "edumazet@...gle.com" <edumazet@...gle.com>,
        "pabeni@...hat.com" <pabeni@...hat.com>
Subject: Re: [PATCH] octeontx2-pf: devlink params support to set TL1 round
 robin priority



> On Mon, 13 May 2024 11:05:46 +0530 Hariprasad Kelam wrote:
> > Added support for setting or modifying transmit level (tl1) round
> > robin priority at runtime via devlink params.
> >
> > Octeontx2 and CN10K silicon's support five transmit levels (TL5 to TL1).
> > On each transmit level Hardware supports DWRR and strict priority,
> > depend on the configuration the hardware will choose the appropriate
> > method to select packets for the next level in the transmission process.
> 
> Configuring DWRR parameters seems in no way HW specific.
> Please work on extending one of the Tx scheduling APIs to express this.
>
  The driver offers per-interface DWRR params configuration with HTB offload.
  Below are example commands having different classid with same priority value

tc class add dev ethx parent 1: classid 1:1 htb rate 10Gbit prio 1 quantum 2048
tc class add dev ethx parent 1: classid 1:2 htb rate 10Gbit prio 1 quantum 3048

Due to a hardware limitation, only a single DWRR group is supported on a transmit level.
To address this for physical functions (PFs) sharing a transmit level with their virtual functions (VFs),
 a devlink option implemented to configure a priority value.

Thanks,
Hariprasad k

> pw-bot: cr