netdev - Re: [PATCH v3] virtio_net: Fix missed rtnl

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CANn89iJjMcZ74eCWqBdTferLtZ1AwyMSiGBkdqMNFMV2t0AREw@mail.gmail.com>
Date: Wed, 15 May 2024 18:39:34 +0200
From: Eric Dumazet <edumazet@...gle.com>
To: Daniel Jurgens <danielj@...dia.com>
Cc: netdev@...r.kernel.org, mst@...hat.com, jasowang@...hat.com, 
	xuanzhuo@...ux.alibaba.com, virtualization@...ts.linux.dev, 
	davem@...emloft.net, kuba@...nel.org, pabeni@...hat.com, jiri@...dia.com, 
	Eric Dumazet <edumaset@...gle.com>
Subject: Re: [PATCH v3] virtio_net: Fix missed rtnl_unlock

On Wed, May 15, 2024 at 6:32 PM Daniel Jurgens <danielj@...dia.com> wrote:
>
> The rtnl_lock would stay locked if allocating promisc_allmulti failed.
> Also changed the allocation to GFP_KERNEL.
>
> Fixes: ff7c7d9f5261 ("virtio_net: Remove command data from control_buf")
> Reported-by: Eric Dumazet <edumaset@...gle.com>
> Link: https://lore.kernel.org/netdev/CANn89iLazVaUCvhPm6RPJJ0owra_oFnx7Fhc8d60gV-65ad3WQ@mail.gmail.com/
> Signed-off-by: Daniel Jurgens <danielj@...dia.com>

Reviewed-by: Eric Dumazet <edumazet@...gle.com>

Thanks !