netdev - Re: [PATCH net 0/2] intel: Interpret .set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZkXHdy6bKGUhIJfO@lzaremba-mobl.ger.corp.intel.com>
Date: Thu, 16 May 2024 10:44:39 +0200
From: Larysa Zaremba <larysa.zaremba@...el.com>
To: Jacob Keller <jacob.e.keller@...el.com>, netdev <netdev@...r.kernel.org>
CC: netdev <netdev@...r.kernel.org>, Jakub Kicinski <kuba@...nel.org>, "David
 Miller" <davem@...emloft.net>, Michal Swiatkowski
	<michal.swiatkowski@...ux.intel.com>, Chandan Kumar Rout
	<chandanx.rout@...el.com>, Pucha Himasekhar Reddy
	<himasekharx.reddy.pucha@...el.com>, Maciej Fijalkowski
	<maciej.fijalkowski@...el.com>, Przemek Kitszel
	<przemyslaw.kitszel@...el.com>, Igor Bagnucki <igor.bagnucki@...el.com>,
	Krishneil Singh <krishneil.k.singh@...el.com>, Simon Horman
	<horms@...nel.org>
Subject: Re: [PATCH net 0/2] intel: Interpret .set_channels() input
 differently

On Tue, May 14, 2024 at 11:51:11AM -0700, Jacob Keller wrote:
> The ice and idpf drivers can trigger a crash with AF_XDP due to incorrect
> interpretation of the asymmetric Tx and Rx parameters in their
> .set_channels() implementations:
> 
> 1. ethtool -l <IFNAME> -> combined: 40
> 2. Attach AF_XDP to queue 30
> 3. ethtool -L <IFNAME> rx 15 tx 15
>    combined number is not specified, so command becomes {rx_count = 15,
>    tx_count = 15, combined_count = 40}.
> 4. ethnl_set_channels checks, if there are any AF_XDP of queues from the
>    new (combined_count + rx_count) to the old one, so from 55 to 40, check
>    does not trigger.
> 5. the driver interprets `rx 15 tx 15` as 15 combined channels and deletes
>    the queue that AF_XDP is attached to.
> 
> This is fundamentally a problem with interpreting a request for asymmetric
> queues as symmetric combined queues.
> 
> Fix the ice and idpf drivers to stop interpreting such requests as a
> request for combined queues. Due to current driver design for both ice and
> idpf, it is not possible to support requests of the same count of Tx and Rx
> queues with independent interrupts, (i.e. ethtool -L <IFNAME> rx 15 tx 15)
> so such requests are now rejected.
> 
> Signed-off-by: Jacob Keller <jacob.e.keller@...el.com>
> ---

Please, do not merge, first patch contains a redundant check

if (!ch->combined_count)

I will send another version.

> Larysa Zaremba (2):
>       ice: Interpret .set_channels() input differently
>       idpf: Interpret .set_channels() input differently
> 
>  drivers/net/ethernet/intel/ice/ice_ethtool.c   | 22 ++++++----------------
>  drivers/net/ethernet/intel/idpf/idpf_ethtool.c | 21 ++++++---------------
>  2 files changed, 12 insertions(+), 31 deletions(-)
> ---
> base-commit: aea27a92a41dae14843f92c79e9e42d8f570105c
> change-id: 20240514-iwl-net-2024-05-14-set-channels-fixes-25be6f04a86d
> 
> Best regards,
> -- 
> Jacob Keller <jacob.e.keller@...el.com>
>