netdev - Re: [PATCH iwl-net V4,1/2] i40e: factoring out i40e_suspend/i40e

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240516085052.GG179178@kernel.org>
Date: Thu, 16 May 2024 09:50:52 +0100
From: Simon Horman <horms@...nel.org>
To: Thinh Tran <thinhtr@...ux.ibm.com>
Cc: netdev@...r.kernel.org, kuba@...nel.org, anthony.l.nguyen@...el.com,
	aleksandr.loktionov@...el.com, przemyslaw.kitszel@...el.com,
	pmenzel@...gen.mpg.de, jesse.brandeburg@...el.com,
	davem@...emloft.net, edumazet@...gle.com, pabeni@...hat.com,
	intel-wired-lan@...ts.osuosl.org, rob.thomas@....com
Subject: Re: [PATCH iwl-net V4,1/2] i40e: factoring out
 i40e_suspend/i40e_resume

On Wed, May 15, 2024 at 04:07:04PM -0500, Thinh Tran wrote:
> Two new functions, i40e_io_suspend() and i40e_io_resume(), have been
> introduced.  These functions were factored out from the existing
> i40e_suspend() and i40e_resume() respectively.  This factoring was
> done due to concerns about the logic of the I40E_SUSPENSED state, which
> caused the device to be unable to recover.  The functions are now used
> in the EEH handling for device suspend/resume callbacks.
> 
> The function i40e_enable_mc_magic_wake() has been moved ahead of
> i40e_io_suspend() to ensure it is declared before being used.
> 
> Tested-by: Robert Thomas <rob.thomas@....com>
> Signed-off-by: Thinh Tran <thinhtr@...ux.ibm.com>

Hi Thrinh,

Sorry to nit-pick, but the request from Paul in his review of v3
was to use imperative mood in the title.

	Factor out i40e_suspend/i40e_resume

In any case, this patch looks good to me.

Reviewed-by: Simon Horman <horms@...nel.org>