[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <18746508-f7d6-4a1c-9758-1e9e1fb35c64@kernel.org>
Date: Sun, 19 May 2024 19:33:20 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Vineeth Karumanchi <vineeth.karumanchi@....com>, git@....com,
davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org,
pabeni@...hat.com, robh@...nel.org, krzk+dt@...nel.org, conor+dt@...nel.org,
harini.katakam@....com, andrew@...n.ch, hkallweit1@...il.com,
linux@...linux.org.uk, michal.simek@....com
Cc: netdev@...r.kernel.org, devicetree@...r.kernel.org,
linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH net-next v2 1/2] dt-bindings: net: xilinx_gmii2rgmii: Add
clock support
On 17/05/2024 07:47, Vineeth Karumanchi wrote:
> Add input clock support to gmii_to_rgmii IP.
> Add "clocks" bindings for the input clock.
Both sentences look like saying the same... confused.
>
> Signed-off-by: Vineeth Karumanchi <vineeth.karumanchi@....com>
> ---
> Documentation/devicetree/bindings/net/xlnx,gmii-to-rgmii.yaml | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/net/xlnx,gmii-to-rgmii.yaml b/Documentation/devicetree/bindings/net/xlnx,gmii-to-rgmii.yaml
> index 0f781dac6717..672bff6dae28 100644
> --- a/Documentation/devicetree/bindings/net/xlnx,gmii-to-rgmii.yaml
> +++ b/Documentation/devicetree/bindings/net/xlnx,gmii-to-rgmii.yaml
> @@ -31,6 +31,9 @@ properties:
> phy-handle:
> $ref: ethernet-controller.yaml#/properties/phy-handle
>
> + clocks:
> + description: 200/375 MHz free-running clock is used as input clock.
Missing constraints. Probably you wanted items above description.
Best regards,
Krzysztof
Powered by blists - more mailing lists