netdev - Re: [PATCH v3 7/8] can: mcp251xfd: add gpio functionality

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e24b16a1-2a69-4aea-9ad0-135ed0a87547@lunn.ch>
Date: Tue, 21 May 2024 22:37:33 +0200
From: Andrew Lunn <andrew@...n.ch>
To: Gregor Herburger <gregor.herburger@...tq-group.com>
Cc: Marc Kleine-Budde <mkl@...gutronix.de>,
	Manivannan Sadhasivam <manivannan.sadhasivam@...aro.org>,
	Thomas Kopp <thomas.kopp@...rochip.com>,
	Vincent Mailhol <mailhol.vincent@...adoo.fr>,
	"David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	Rob Herring <robh@...nel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
	Conor Dooley <conor+dt@...nel.org>, linux-can@...r.kernel.org,
	netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
	devicetree@...r.kernel.org, linux@...tq-group.com
Subject: Re: [PATCH v3 7/8] can: mcp251xfd: add gpio functionality

On Tue, May 21, 2024 at 03:04:57PM +0200, Gregor Herburger wrote:
> The mcp251xfd devices allow two pins to be configured as gpio. Add this
> functionality to driver.

I have a basic understanding of GPIO drivers, which is probably more
than average for netdev reviewers. This code looks O.K. to me, but i
would prefer you run it by the GPIO maintainers, since that is there
domain of expertise. I don't think any are in Cc:

    Andrew

---
pw-bot: cr