netdev - Re: [PATCH bpf-next v2 3/4] samples/bpf: Add bpf sample to offload flowtable traffic to xdp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAADnVQLV4=mQ3+2baLhfJi_m6A72khNxUhcgPuv+sdQqE7skgA@mail.gmail.com>
Date: Mon, 20 May 2024 18:45:00 -0700
From: Alexei Starovoitov <alexei.starovoitov@...il.com>
To: Lorenzo Bianconi <lorenzo@...nel.org>
Cc: bpf <bpf@...r.kernel.org>, Pablo Neira Ayuso <pablo@...filter.org>, 
	Jozsef Kadlecsik <kadlec@...filter.org>, "David S. Miller" <davem@...emloft.net>, 
	Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, 
	netfilter-devel <netfilter-devel@...r.kernel.org>, 
	Network Development <netdev@...r.kernel.org>, Alexei Starovoitov <ast@...nel.org>, 
	Daniel Borkmann <daniel@...earbox.net>, Andrii Nakryiko <andrii@...nel.org>, 
	Lorenzo Bianconi <lorenzo.bianconi@...hat.com>, Toke Høiland-Jørgensen <toke@...hat.com>, 
	Florian Westphal <fw@...len.de>, Jesper Dangaard Brouer <hawk@...nel.org>, Simon Horman <horms@...nel.org>, donhunte@...hat.com, 
	Kumar Kartikeya Dwivedi <memxor@...il.com>
Subject: Re: [PATCH bpf-next v2 3/4] samples/bpf: Add bpf sample to offload
 flowtable traffic to xdp

On Sat, May 18, 2024 at 3:13 AM Lorenzo Bianconi <lorenzo@...nel.org> wrote:
>
> Introduce xdp_flowtable_offload bpf sample to offload sw flowtable logic
> in xdp layer if hw flowtable is not available or does not support a
> specific kind of traffic.
>
> Signed-off-by: Lorenzo Bianconi <lorenzo@...nel.org>
> ---
>  samples/bpf/Makefile                     |   7 +-
>  samples/bpf/xdp_flowtable_offload.bpf.c  | 591 +++++++++++++++++++++++
>  samples/bpf/xdp_flowtable_offload_user.c | 128 +++++
>  3 files changed, 725 insertions(+), 1 deletion(-)
>  create mode 100644 samples/bpf/xdp_flowtable_offload.bpf.c
>  create mode 100644 samples/bpf/xdp_flowtable_offload_user.c

I feel this sample code is dead on arrival.
Make selftest more real if you want people to use it as an example,
but samples dir is just a dumping ground.
We shouldn't be adding anything to it.