netdev - Re: "netlink error: Invalid argument" with ethtool-5.13+ on recent kernels due to "ethtool: Add netlink handler for getmodule (-m)" - 25b64c66f58d3df0ad7272dda91c3ab06fe7a303, also no SFP-DOM support via netlink?

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <43f55709-4234-41e3-b6c4-8a069ea7ac6a@ans.pl>
Date: Tue, 21 May 2024 00:16:56 -0700
From: Krzysztof Olędzki <ole@....pl>
To: Michal Kubecek <mkubecek@...e.cz>
Cc: Moshe Shemesh <moshe@...dia.com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: Re: "netlink error: Invalid argument" with ethtool-5.13+ on recent
 kernels due to "ethtool: Add netlink handler for getmodule (-m)" -
 25b64c66f58d3df0ad7272dda91c3ab06fe7a303, also no SFP-DOM support via
 netlink?

On 21.05.2024 at 00:02, Krzysztof Olędzki wrote:
> -vladyslavt@...dia.com (User unknown).
> 
> Hi Michal,
> 
> On 20.05.2024 at 23:55, Michal Kubecek wrote:
>> On Mon, May 20, 2024 at 11:26:56PM -0700, Krzysztof Olędzki wrote:
>>> Hi,
>>>
>>> After upgrading from 5.4-stable to 6.6-stable I noticed that modern ethtool -m stopped working with ports where I have QSFP modules installed in my CX3 / CX3-Pro cards.
>>>
>>> Git bisect identified the following patch as being responsible for the issue:
>>> https://git.kernel.org/pub/scm/network/ethtool/ethtool.git/commit/?id=25b64c66f58d3df0ad7272dda91c3ab06fe7a303
>>
>> Sounds like the issue that was fixed by commit 1a1dcfca4d67 ("ethtool:
>> Fix SFF-8472 transceiver module identification"). Can you try ethtool
>> version 6.7?
> 
> Yes, forgot to mention - this problem also exists in ethtool-6.7:
> 
> # ./ethtool  --version
> ethtool version 6.7
> 
> # ./ethtool --debug 3 -m eth3
> sending genetlink packet (32 bytes):
>     msg length 32 genl-ctrl
> received genetlink packet (956 bytes):
>     msg length 956 genl-ctrl
> received genetlink packet (36 bytes):
>     msg length 36 error errno=0
> sending genetlink packet (76 bytes):
>     msg length 76 ethool ETHTOOL_MSG_MODULE_EEPROM_GET
> received genetlink packet (52 bytes):
>     msg length 52 ethool ETHTOOL_MSG_MODULE_EEPROM_GET_REPLY
> received genetlink packet (36 bytes):
>     msg length 36 error errno=0
> sending genetlink packet (76 bytes):
>     msg length 76 ethool ETHTOOL_MSG_MODULE_EEPROM_GET
> received genetlink packet (176 bytes):
>     msg length 176 ethool ETHTOOL_MSG_MODULE_EEPROM_GET_REPLY
> received genetlink packet (36 bytes):
>     msg length 36 error errno=0
> sending genetlink packet (76 bytes):
>     msg length 76 ethool ETHTOOL_MSG_MODULE_EEPROM_GET
> received genetlink packet (176 bytes):
>     msg length 176 ethool ETHTOOL_MSG_MODULE_EEPROM_GET_REPLY
> received genetlink packet (36 bytes):
>     msg length 36 error errno=0
> sending genetlink packet (76 bytes):
>     msg length 76 ethool ETHTOOL_MSG_MODULE_EEPROM_GET
> received genetlink packet (96 bytes):
>     msg length 96 error errno=-22
> netlink error: Invalid argument

That said, DOM seems to work since 5.19 because it includes:
 https://git.kernel.org/pub/scm/network/ethtool/ethtool.git/commit/sfpid.c?id=fb92de62eeb1cfbb21f57d60491798df762556d3

Sorry, got confused with my git bisect.

So, we are down to the main issue - Invalid argument for QSFP.

Thanks,
 Krzysztof