netdev - Re: [PATCH bpf-next v2 3/4] samples/bpf: Add bpf sample to offload flowtable traffic to xdp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Tue, 21 May 2024 15:19:48 +0200
From: Lorenzo Bianconi <lorenzo@...nel.org>
To: Toke Høiland-Jørgensen <toke@...hat.com>
Cc: Alexei Starovoitov <alexei.starovoitov@...il.com>,
	bpf <bpf@...r.kernel.org>, Pablo Neira Ayuso <pablo@...filter.org>,
	Jozsef Kadlecsik <kadlec@...filter.org>,
	"David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	netfilter-devel <netfilter-devel@...r.kernel.org>,
	Network Development <netdev@...r.kernel.org>,
	Alexei Starovoitov <ast@...nel.org>,
	Daniel Borkmann <daniel@...earbox.net>,
	Andrii Nakryiko <andrii@...nel.org>,
	Lorenzo Bianconi <lorenzo.bianconi@...hat.com>,
	Florian Westphal <fw@...len.de>,
	Jesper Dangaard Brouer <hawk@...nel.org>,
	Simon Horman <horms@...nel.org>, donhunte@...hat.com,
	Kumar Kartikeya Dwivedi <memxor@...il.com>
Subject: Re: [PATCH bpf-next v2 3/4] samples/bpf: Add bpf sample to offload
 flowtable traffic to xdp

> Alexei Starovoitov <alexei.starovoitov@...il.com> writes:
> 
> > On Sat, May 18, 2024 at 3:13 AM Lorenzo Bianconi <lorenzo@...nel.org> wrote:
> >>
> >> Introduce xdp_flowtable_offload bpf sample to offload sw flowtable logic
> >> in xdp layer if hw flowtable is not available or does not support a
> >> specific kind of traffic.
> >>
> >> Signed-off-by: Lorenzo Bianconi <lorenzo@...nel.org>
> >> ---
> >>  samples/bpf/Makefile                     |   7 +-
> >>  samples/bpf/xdp_flowtable_offload.bpf.c  | 591 +++++++++++++++++++++++
> >>  samples/bpf/xdp_flowtable_offload_user.c | 128 +++++
> >>  3 files changed, 725 insertions(+), 1 deletion(-)
> >>  create mode 100644 samples/bpf/xdp_flowtable_offload.bpf.c
> >>  create mode 100644 samples/bpf/xdp_flowtable_offload_user.c
> >
> > I feel this sample code is dead on arrival.
> > Make selftest more real if you want people to use it as an example,
> > but samples dir is just a dumping ground.
> > We shouldn't be adding anything to it.
> 
> Agreed. We can integrate a working sample into xdp-tools instead :)

ack fine, I can post a patch for xdp-tools.

Regards,
Lorenzo

> 
> -Toke
> 

Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)