netdev - Re: [PATCH v2] net: mhi: set skb mac header before entering RX path

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <d208bf59246120f47c4366ddf9b88431c761dba8.camel@redhat.com>
Date: Wed, 22 May 2024 10:36:02 +0200
From: Paolo Abeni <pabeni@...hat.com>
To: Martin Fäcknitz <faecknitz@...splots.de>, 
	netdev@...r.kernel.org
Cc: mhi@...ts.linux.dev
Subject: Re: [PATCH v2] net: mhi: set skb mac header before entering RX path

On Fri, 2024-05-17 at 23:19 +0200, Martin Fäcknitz wrote:
> skb->mac_header must be set before passing the skb to the network stack,
> because skb->mac_len is calculated from skb->mac_header in
> __netif_receive_skb_core.
> 
> Some network stack components, like xfrm, are using skb->mac_len to
> check for an existing MAC header, which doesn't exist in this case. This
> leads to memory corruption.
> 
> Fixes: 7ffa7542eca6 ("net: mhi: Remove MBIM protocol")

I'm possibly missing something, but the above tag looks incorrect:
AFAICS the mac header was not set even before such commit for the non
WWAN case.

Thanks,

Paolo