netdev - Re: "netlink error: Invalid argument" with ethtool-5.13+ on recent kernels due to "ethtool: Add netlink handler for getmodule (-m)" - 25b64c66f58d3df0ad7272dda91c3ab06fe7a303, also no SFP-DOM support via netlink?

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f9cec087-d3e1-4d06-b645-47429316feb7@lunn.ch>
Date: Wed, 22 May 2024 14:44:24 +0200
From: Andrew Lunn <andrew@...n.ch>
To: Ido Schimmel <idosch@...dia.com>
Cc: Krzysztof Olędzki <ole@....pl>,
	Michal Kubecek <mkubecek@...e.cz>, Moshe Shemesh <moshe@...dia.com>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	tariqt@...dia.com
Subject: Re: "netlink error: Invalid argument" with ethtool-5.13+ on recent
 kernels due to "ethtool: Add netlink handler for getmodule (-m)" -
 25b64c66f58d3df0ad7272dda91c3ab06fe7a303, also no SFP-DOM support via
 netlink?

> > So right, the function returns 512 for SFP and 256 for everything else, which explains why SFP does work but QSFP - not.
> 
> Since you already did all the work and you are able to test patches, do
> you want to fix it yourself and submit or report to the mlx4 maintainer
> (copied)? Fix should be similar to mlx5 commit a708fb7b1f8d ("net/mlx5e:
> ethtool, Add support for EEPROM high pages query").

Before you do that, please could you work on ethtool. I would say it
has a bug. It has been provided with 256 bytes of SPF data. It should
be able to decode that and print it in human readable format. So the
EINVAL should not be considered fatal to decoding.

       Andrew