netdev - Re: r8169: Crash with TX segmentation offload on RTL8125

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240522065550.32d37359@kernel.org>
Date: Wed, 22 May 2024 06:55:50 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Florian Fainelli <f.fainelli@...il.com>
Cc: Ken Milmore <ken.milmore@...il.com>, "netdev@...r.kernel.org"
 <netdev@...r.kernel.org>, Heiner Kallweit <hkallweit1@...il.com>, Realtek
 linux nic maintainers <nic_swsd@...ltek.com>, Eric Dumazet
 <edumazet@...gle.com>
Subject: Re: r8169: Crash with TX segmentation offload on RTL8125

On Fri, 17 May 2024 15:21:00 -0700 Florian Fainelli wrote:
> > The patch below fixes the problem, by simply reading nr_frags a bit later, after the checksum stage.  
> 
> Yeah, that's an excellent catch and one that is bitten us before, too:
> 
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=20d1f2d1b024f6be199a3bedf1578a1d21592bc5
> 
> unclear what we would do in skb_shinfo() to help driver writers, rather 
> than rely upon code inspection to find such bugs.

I wonder if we should add a "error injection" hook under DEBUG_NET
to force re-allocation of skbs in any helper which may cause it?