netdev - Re: [PATCH v5 00/68] Define _GNU

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240522101349.565a745e@kernel.org>
Date: Wed, 22 May 2024 10:13:49 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Shuah Khan <skhan@...uxfoundation.org>, Andrew Morton
 <akpm@...ux-foundation.org>
Cc: Edward Liaw <edliaw@...gle.com>, shuah@...nel.org, Mickaël Salaün <mic@...ikod.net>, Günther
 Noack <gnoack@...gle.com>, Christian Brauner <brauner@...nel.org>, Richard
 Cochran <richardcochran@...il.com>, Paul Walmsley
 <paul.walmsley@...ive.com>, Palmer Dabbelt <palmer@...belt.com>, Albert Ou
 <aou@...s.berkeley.edu>, Alexei Starovoitov <ast@...nel.org>, Daniel
 Borkmann <daniel@...earbox.net>, "David S. Miller" <davem@...emloft.net>,
 Jesper Dangaard Brouer <hawk@...nel.org>, John Fastabend
 <john.fastabend@...il.com>, linux-kernel@...r.kernel.org,
 linux-kselftest@...r.kernel.org, kernel-team@...roid.com,
 linux-security-module@...r.kernel.org, netdev@...r.kernel.org,
 linux-riscv@...ts.infradead.org, bpf@...r.kernel.org
Subject: Re: [PATCH v5 00/68] Define _GNU_SOURCE for sources using

On Wed, 22 May 2024 10:19:33 -0600 Shuah Khan wrote:
> On 5/21/24 18:56, Edward Liaw wrote:
> > Centralizes the definition of _GNU_SOURCE into KHDR_INCLUDES and removes
> > redefinitions of _GNU_SOURCE from source code.
> > 
> > 809216233555 ("selftests/harness: remove use of LINE_MAX") introduced
> > asprintf into kselftest_harness.h, which is a GNU extension and needs  
> 
> Easier solution to define LINE_MAX locally. In gerenal it is advisable
> to not add local defines, but it is desirable in some cases to avoid
> churn like this one.

Will the patch that Andrew applied:
https://lore.kernel.org/all/20240519213733.2AE81C32781@smtp.kernel.org/
make its way to Linus? As you say that's a much simpler fix.