[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <683225e0-1cd3-4dea-bb68-086d46b233e8@broadcom.com>
Date: Wed, 22 May 2024 16:39:57 -0700
From: Alexey Makhalov <alexey.makhalov@...adcom.com>
To: Simon Horman <horms@...nel.org>
Cc: linux-kernel@...r.kernel.org, virtualization@...ts.linux.dev,
bp@...en8.de, hpa@...or.com, dave.hansen@...ux.intel.com, mingo@...hat.com,
tglx@...utronix.de, x86@...nel.org, netdev@...r.kernel.org,
richardcochran@...il.com, linux-input@...r.kernel.org,
dmitry.torokhov@...il.com, zackr@...are.com,
linux-graphics-maintainer@...are.com, pv-drivers@...are.com,
timothym@...are.com, akaher@...are.com, dri-devel@...ts.freedesktop.org,
daniel@...ll.ch, airlied@...il.com, tzimmermann@...e.de, mripard@...nel.org,
maarten.lankhorst@...ux.intel.com, kirill.shutemov@...ux.intel.com,
Nadav Amit <nadav.amit@...il.com>, Jeff Sipek <jsipek@...are.com>
Subject: Re: [PATCH v9 3/8] x86/vmware: Introduce VMware hypercall API
Hi Simon, apologize for long delay
On 5/11/24 8:02 AM, Simon Horman wrote:
>> diff --git a/arch/x86/include/asm/vmware.h b/arch/x86/include/asm/vmware.h
>
> ...
>
>> +static inline
>> +unsigned long vmware_hypercall3(unsigned long cmd, unsigned long in1,
>> + uint32_t *out1, uint32_t *out2)
>
> nit: u32 is preferred over uint32_t.
> Likewise elsewhere in this patch-set.
Good to know. Can you please shed a light on the reason?
I still see bunch of stdint style uint32_t in arch/x86.
> ...
>
>> /*
>> - * The high bandwidth in call. The low word of edx is presumed to have the
>> - * HB bit set.
>> + * High bandwidth calls are not supported on encrypted memory guests.
>> + * The caller should check cc_platform_has(CC_ATTR_MEM_ENCRYPT) and use
>> + * low bandwidth hypercall it memory encryption is set.
>> + * This assumption simplifies HB hypercall impementation to just I/O port
>
> nit: implementation
>
> checkpatch.pl --codespell is your friend
Thanks, that is useful!
>
>> + * based approach without alternative patching.
>> */
>
> ...
Powered by blists - more mailing lists