netdev - Re: iproute2: color output should assume dark background

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c41ee2a968d1b839b8b9c7a3571ad107@manjaro.org>
Date: Thu, 23 May 2024 16:24:17 +0200
From: Dragan Simic <dsimic@...jaro.org>
To: Gedalya <gedalya@...alya.net>
Cc: Sirius <sirius@...dheim.com>, netdev@...r.kernel.org
Subject: Re: iproute2: color output should assume dark background

On 2024-05-23 16:11, Gedalya wrote:
> On 5/23/24 10:02 PM, Dragan Simic wrote:
>> See, once something becomes de facto standard, or some kind of de 
>> facto
>> standard, it becomes quite hard to change it.  It's often required to
>> offer much greater flexibility instead of just changing it.
>> 
> Flexibility is offered by the COLORFGBG variable. The entire time
> we've been talking only about cases where that is not set.

Yes, but the actual trouble is that COLORFGBG seems to be rarely set
automatically by the terminal emulators.

> Again, it is good to reduce to a minimum reliance on defaults. But
> aside from having a default the remaining option is to refuse to
> produce colors when COLORFGBG is not set, even when the user is
> explicitly asking for colors.

That's a very good proposal!  I'd highly support that behavior.

>>>> everywhere and for the new feature to reach the users.  Shipping
>>>> a few additional files in the /etc/profile.d directory would be a
>>>> reasonable stopgap measure.
>>> 
>>> No, it would be totally broken as explained.
>> 
>> It would be broken only for those users who change their background
>> color to some light color.  Though, it would be broken even with your
>> patch applied, right?  I see no difference in the end results, for the
>> users that reconfigure their terminals that way.
>> 
> /etc/profile.d is shell session configuration.
> 
> If you want you can come up with shell magic that would set
> environment variables depending on which terminal environment the
> shell is running in.

I had in mind setting COLORFGBG to dark background that way, not some
shell magic that would change it dynamically.