netdev - net: dsa: mv88e6xxx: Help needed: Serdes with SFP not working with mv88e6320 on Linux 5.4

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID:
 <BEZP281MB27767E9FDEBECA454A503C4090F42@BEZP281MB2776.DEUP281.PROD.OUTLOOK.COM>
Date: Thu, 23 May 2024 22:38:36 +0000
From: Daniel Glinka <daniel.glinka@...ntys.de>
To: Andrew Lunn <andrew@...n.ch>
CC: "netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: net: dsa: mv88e6xxx: Help needed: Serdes with SFP not working with
 mv88e6320 on Linux 5.4

>> So, assuming you can use 6.9...
>
>> mv88e6320_ops does not have a .pcs_ops member. So the SERDES is not
>> getting configured. Taking a quick look at the datasheet, the SERDES
>> appears to be similar to the 6352 SERDES. However, the 6532 only has a
>> single SERDES, where as the 6320 has two of them. And they are at a
>> different address, 0xC and 0xD, where as the 6532 uses 0xF.

>> You can probably use pcs-6352.c as a template in order to produce
>> pcs-6320.c. Actually, you might be able to extend it, adding just
>> 6320 specific versions of:
>> 
>> const struct mv88e6xxx_pcs_ops mv88e6352_pcs_ops = {
>>        .pcs_init = mv88e6352_pcs_init,
>>        .pcs_teardown = mv88e6352_pcs_teardown,
>>        .pcs_select = mv88e6352_pcs_select,
>>};
>> 
>> to the end.
>>
>>        Andrew
>Thanks for the suggestion! I will try this.
>
>Daniel

I had a look at the implementation. But switching to the fiber/serdes page does not work. I did some debugging and it seems the page is not properly set in the  mv88e6xxx_phy_page_get call. The function returns 0, but if I want to read the value back I get 0xFFFF. I also tried to write to the register using the mdio-tools (https://github.com/wkz/mdio-tools) with the same behavior.  But this is only on the SERDES ports. Therefore I would assume mdio works fine.
I thought it was because we have no phy (cmode is 0x9). Could this be a different issue?

Daniel