netdev - RE: Re: [PATCH v2] ax25: Fix refcount imbalance on inbound connections

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: 
 <SJ2PR18MB56353DBBA807AE7F40F5206DA2F42@SJ2PR18MB5635.namprd18.prod.outlook.com>
Date: Thu, 23 May 2024 06:37:33 +0000
From: Naveen Mamindlapalli <naveenm@...vell.com>
To: Lars Kellogg-Stedman <lars@...bit.com>
CC: "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "linux-hams@...r.kernel.org" <linux-hams@...r.kernel.org>
Subject: RE: Re: [PATCH v2] ax25: Fix refcount imbalance on inbound
 connections


> -----Original Message-----
> From: Lars Kellogg-Stedman <lars@...bit.com>
> Sent: Tuesday, May 21, 2024 11:27 PM
> To: Naveen Mamindlapalli <naveenm@...vell.com>
> Cc: netdev@...r.kernel.org; linux-hams@...r.kernel.org
> Subject: Re: [PATCH v2] ax25: Fix refcount imbalance on inbound
> connections
> 
> On Tue, May 21, 2024 at 05:21:40PM GMT, Naveen Mamindlapalli wrote:
> > > socket *newsock,
> > >  	DEFINE_WAIT(wait);
> > >  	struct sock *sk;
> > >  	int err = 0;
> > > +	ax25_cb *ax25;
> > > +	ax25_dev *ax25_dev;
> >
> > nit: Please follow reverse Christmas tree.
> 
> That is a new phrase for me; I had to look it up. Do you mean this:
> 
>         DEFINE_WAIT(wait);
>         struct sock *sk;
>         int err = 0;
> +	      ax25_dev *ax25_dev;
> +	      ax25_cb *ax25;
> 
> Or should I apply this to the entire block of variable declarations, like this:
> 
>         struct sk_buff *skb;
>         struct sock *newsk;
> +       ax25_dev *ax25_dev;
>         DEFINE_WAIT(wait);
>         struct sock *sk;
> +       ax25_cb *ax25;
>         int err = 0;

Yes, apply reverse xmas tree order to entire block.

Thanks,
Naveen

> 
> Thanks,
> 
> --
> Lars Kellogg-Stedman <lars@...bit.com> | larsks @ {irc,twitter,github}
> https://urldefense.proofpoint.com/v2/url?u=http-
> 3A__blog.oddbit.com_&d=DwIBAg&c=nKjWec2b6R0mOyPaz7xtfQ&r=TwreqwV6
> mQ8K9wIpqwFO8yjikO_w1jUOe2MzChg4Rmg&m=FtlS2pOuM2TyZSjXUe6s5L7w
> o2YtvcK9Ep3HQRqf8dMeSy9VLui3rMQDUcVMFLcK&s=0fvO6BKSQQg3niGImy4
> VLvjVZ0kOAeAjIB2WwdZNYRs&e=                 | N1LKS