netdev - Re: [PATCH bpf-next] selftests/bpf: test_sockmap, use section names understood by libbpf

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Thu, 23 May 2024 14:57:11 +0800
From: Geliang Tang <geliang@...nel.org>
To: Jakub Sitnicki <jakub@...udflare.com>
Cc: bpf@...r.kernel.org, netdev@...r.kernel.org, Alexei Starovoitov
	 <ast@...nel.org>, Daniel Borkmann <daniel@...earbox.net>, Andrii Nakryiko
	 <andrii@...nel.org>, John Fastabend <john.fastabend@...il.com>
Subject: Re: [PATCH bpf-next] selftests/bpf: test_sockmap, use section names
 understood by libbpf

Hi Jakub,

On Wed, 2024-05-22 at 12:26 +0200, Jakub Sitnicki wrote:
> On Wed, May 22, 2024 at 06:12 PM +08, Geliang Tang wrote:
> > On Wed, 2024-05-22 at 10:09 +0200, Jakub Sitnicki wrote:
> 
> [...]
> 
> > prog_attach_type is still used by my commit:
> > 
> > https://lore.kernel.org/bpf/e27d7d0c1e0e79b0acd22ac6ad5d8f9f00225303.1716372485.git.tanggeliang@kylinos.cn/T/#u

I changes my commit above as "Rejected". So this patch is ready to
apply now.

> > Please review it for me.
> > 
> > If my commit is acceptable, this patch will conflict with it. It's
> > a
> > bit strange to delete this prog_attach_type in your patch and then
> > add
> > it back in my commit. So could you please rebase this patch on my
> > commit in that case. Sorry for the trouble.
> 
> If you want to help improve and modernize this test code, I suggest
> switching attachments to bpf_link instead, they are now available for
> sockmap:

Here's the patches for switching attachments to bpf_link, together with
some small fixes and cleanups:

https://patchwork.kernel.org/project/netdevbpf/cover/cover.1716446893.git.tanggeliang@kylinos.cn/

Please review them for me.

Thanks,
-Geliang

> 
> https://lore.kernel.org/bpf/20240408152451.4162024-1-yonghong.song@linux.dev/
>