netdev - Re: "netlink error: Invalid argument" with ethtool-5.13+ on recent kernels due to "ethtool: Add netlink handler for getmodule (-m)" - 25b64c66f58d3df0ad7272dda91c3ab06fe7a303, also no SFP-DOM support via netlink?

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2pg2m5byszc7qbzxii3ag2v5kzptny2vv4nssatfwrixy4gdd6@fvvnwy2gccsb>
Date: Thu, 23 May 2024 12:37:28 +0200
From: Michal Kubecek <mkubecek@...e.cz>
To: Krzysztof Olędzki <ole@....pl>
Cc: Andrew Lunn <andrew@...n.ch>, Ido Schimmel <idosch@...dia.com>, 
	Moshe Shemesh <moshe@...dia.com>, "netdev@...r.kernel.org" <netdev@...r.kernel.org>, 
	tariqt@...dia.com
Subject: Re: "netlink error: Invalid argument" with ethtool-5.13+ on recent
 kernels due to "ethtool: Add netlink handler for getmodule (-m)" -
 25b64c66f58d3df0ad7272dda91c3ab06fe7a303, also no SFP-DOM support via
 netlink?

On Wed, May 22, 2024 at 10:29:43PM -0700, Krzysztof Olędzki wrote:
> Do you think it would make sense to print a warning in such situation,
> or just handle this silently?

Unless part of the data not being available is something that should be
expected to happen even if there is nothing wrong (which doesn't seem to
be the case), there should IMHO be a warning that the information shown
is incomplete.

I would also consider a short comment in the code explaining that
returning 0 after request failure is intentional.

Michal

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)