netdev - Re: [PATCH net v2 0/2] intel: Interpret .set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: 
 <171646262913.15895.17957174467563014841.git-patchwork-notify@kernel.org>
Date: Thu, 23 May 2024 11:10:29 +0000
From: patchwork-bot+netdevbpf@...nel.org
To: Jacob Keller <jacob.e.keller@...el.com>
Cc: davem@...emloft.net, kuba@...nel.org, netdev@...r.kernel.org,
 larysa.zaremba@...el.com, michal.swiatkowski@...ux.intel.com,
 chandanx.rout@...el.com, himasekharx.reddy.pucha@...el.com,
 maciej.fijalkowski@...el.com, przemyslaw.kitszel@...el.com,
 igor.bagnucki@...el.com, krishneil.k.singh@...el.com, horms@...nel.org
Subject: Re: [PATCH net v2 0/2] intel: Interpret .set_channels() input
 differently

Hello:

This series was applied to netdev/net.git (main)
by Paolo Abeni <pabeni@...hat.com>:

On Tue, 21 May 2024 12:39:52 -0700 you wrote:
> The ice and idpf drivers can trigger a crash with AF_XDP due to incorrect
> interpretation of the asymmetric Tx and Rx parameters in their
> .set_channels() implementations:
> 
> 1. ethtool -l <IFNAME> -> combined: 40
> 2. Attach AF_XDP to queue 30
> 3. ethtool -L <IFNAME> rx 15 tx 15
>    combined number is not specified, so command becomes {rx_count = 15,
>    tx_count = 15, combined_count = 40}.
> 4. ethnl_set_channels checks, if there are any AF_XDP of queues from the
>    new (combined_count + rx_count) to the old one, so from 55 to 40, check
>    does not trigger.
> 5. the driver interprets `rx 15 tx 15` as 15 combined channels and deletes
>    the queue that AF_XDP is attached to.
> 
> [...]

Here is the summary with links:
  - [net,v2,1/2] ice: Interpret .set_channels() input differently
    https://git.kernel.org/netdev/net/c/05d6f442f31f
  - [net,v2,2/2] idpf: Interpret .set_channels() input differently
    https://git.kernel.org/netdev/net/c/5e7695e0219b

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html