netdev - Re: [PATCH bpf-next v2 2/2] selftests: bpf: validate CHECKSUM

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4ed19773-2a26-4652-bd62-0fc0e5c1233e@linux.dev>
Date: Fri, 24 May 2024 17:23:58 +0100
From: Vadim Fedorenko <vadim.fedorenko@...ux.dev>
To: Daniel Borkmann <daniel@...earbox.net>, Vadim Fedorenko
 <vadfed@...a.com>, Martin KaFai Lau <martin.lau@...ux.dev>,
 Andrii Nakryiko <andrii@...nel.org>, Alexei Starovoitov <ast@...nel.org>,
 Mykola Lysenko <mykolal@...com>, Jakub Kicinski <kuba@...nel.org>
Cc: bpf@...r.kernel.org, netdev@...r.kernel.org
Subject: Re: [PATCH bpf-next v2 2/2] selftests: bpf: validate
 CHECKSUM_COMPLETE option

On 24/05/2024 17:18, Daniel Borkmann wrote:
> On 5/24/24 1:06 PM, Vadim Fedorenko wrote:
>> Adjust skb program test to run with checksum validation.
>>
>> Signed-off-by: Vadim Fedorenko <vadfed@...a.com>
> 
> BPF CI complains :
> 
>    [...]
>    
> /tmp/work/bpf/bpf/tools/testing/selftests/bpf/prog_tests/test_skb_pkt_end.c:14:12: error: call to undeclared function 'BIT'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
>       14 |                 .flags = BPF_F_TEST_SKB_CHECKSUM_COMPLETE,
>          |                          ^
>    /tmp/work/bpf/bpf/tools/include/uapi/linux/bpf.h:1429:42: note: 
> expanded from macro 'BPF_F_TEST_SKB_CHECKSUM_COMPLETE'
>     1429 | #define BPF_F_TEST_SKB_CHECKSUM_COMPLETE        BIT(2)
>          |                                                 ^
>    1 error generated.
>    make: *** [Makefile:654: 
> /tmp/work/bpf/bpf/tools/testing/selftests/bpf/test_skb_pkt_end.test.o] 
> Error 1
>    make: *** Waiting for unfinished jobs....
>    make: Leaving directory '/tmp/work/bpf/bpf/tools/testing/selftests/bpf'
>    Error: Process completed with exit code 2.

Oops, looks like checkpatch.pl was too smart and replaced original
define with BIT() macro, but in one file only. I'll re-send it with
fixes.