netdev - Re: [Intel-wired-lan] [PATCH iwl-next v3 1/3] ice: Extend Sideband Queue command to support flags

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <df1f4dc1-446c-468f-83ba-8cd27ff39014@intel.com>
Date: Fri, 24 May 2024 14:12:56 -0700
From: Jacob Keller <jacob.e.keller@...el.com>
To: Paul Menzel <pmenzel@...gen.mpg.de>, Anil Samal <anil.samal@...el.com>
CC: <intel-wired-lan@...ts.osuosl.org>, <netdev@...r.kernel.org>,
	<lukasz.czapnik@...el.com>, <leszek.pepiak@...el.com>,
	<anthony.l.nguyen@...el.com>, Simon Horman <horms@...nel.org>,
	<przemyslaw.kitszel@...el.com>
Subject: Re: [Intel-wired-lan] [PATCH iwl-next v3 1/3] ice: Extend Sideband
 Queue command to support flags



On 5/24/2024 1:43 PM, Paul Menzel wrote:
> Dear Anil,
> 
> 
> Thank you for your patch.
> 
> Am 24.05.24 um 15:51 schrieb Anil Samal:
>>      Current driver implementation for Sideband Queue supports a
>>      fixed flag (ICE_AQ_FLAG_RD). To retrieve FEC statistics from
>>      firmware, Sideband Queue command is used with a different flag.
>>
>>      Extend API for Sideband Queue command to use 'flags' as input
>>      argument.
> 
> Please use `git format-patch`, and not `git show` to send patches. At 
> least that is what I assume the unwanted indentation comes from.
> 
> […]
> 
> 
> Kind regards,
> 
> Paul

While rebasing, please address the commit message formatting. The rest
of your submission does look like it has come from git format-patch or
git send-email, but we don't want to have this extra indentation in the
commit message, as it would then later be indented even further when the
commit is displayed via git show or git log.

Thanks,
Jake