netdev - Re: [PATCH net] net: ti: icssg-prueth: Fix start counter for ft1 filter

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <bf1f7e35-45f9-4129-a41e-d255ad00c917@gmail.com>
Date: Fri, 24 May 2024 15:05:47 -0700
From: Florian Fainelli <f.fainelli@...il.com>
To: MD Danish Anwar <danishanwar@...com>, Andrew Lunn <andrew@...n.ch>,
 Diogo Ivo <diogo.ivo@...mens.com>, Jan Kiszka <jan.kiszka@...mens.com>,
 Paolo Abeni <pabeni@...hat.com>, Jakub Kicinski <kuba@...nel.org>,
 Eric Dumazet <edumazet@...gle.com>, "David S. Miller" <davem@...emloft.net>
Cc: linux-kernel@...r.kernel.org, netdev@...r.kernel.org,
 linux-arm-kernel@...ts.infradead.org, srk@...com,
 Vignesh Raghavendra <vigneshr@...com>, Roger Quadros <rogerq@...nel.org>
Subject: Re: [PATCH net] net: ti: icssg-prueth: Fix start counter for ft1
 filter

On 5/24/24 02:37, MD Danish Anwar wrote:
> The start counter for FT1 filter is wrongly set to 0 in the driver.
> FT1 is used for source address violation (SAV) check and source address
> starts at Byte 6 not Byte 0. Fix this by changing start counter to 6 in
> icssg_ft1_set_mac_addr().
> 
> Fixes: e9b4ece7d74b ("net: ti: icssg-prueth: Add Firmware config and classification APIs.")
> Signed-off-by: MD Danish Anwar <danishanwar@...com>

Would using ETH_ALEN not be a bit clearer here?

> ---
>   drivers/net/ethernet/ti/icssg/icssg_classifier.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/ethernet/ti/icssg/icssg_classifier.c b/drivers/net/ethernet/ti/icssg/icssg_classifier.c
> index 79ba47bb3602..8dee737639b6 100644
> --- a/drivers/net/ethernet/ti/icssg/icssg_classifier.c
> +++ b/drivers/net/ethernet/ti/icssg/icssg_classifier.c
> @@ -455,7 +455,7 @@ void icssg_ft1_set_mac_addr(struct regmap *miig_rt, int slice, u8 *mac_addr)
>   {
>   	const u8 mask_addr[] = { 0, 0, 0, 0, 0, 0, };
>   
> -	rx_class_ft1_set_start_len(miig_rt, slice, 0, 6);
> +	rx_class_ft1_set_start_len(miig_rt, slice, 6, 6);
>   	rx_class_ft1_set_da(miig_rt, slice, 0, mac_addr);
>   	rx_class_ft1_set_da_mask(miig_rt, slice, 0, mask_addr);
>   	rx_class_ft1_cfg_set_type(miig_rt, slice, 0, FT1_CFG_TYPE_EQ);
> 
> base-commit: 66ad4829ddd0b5540dc0b076ef2818e89c8f720e

-- 
Florian