netdev - Re: [PATCH net-next] virtio-net: synchronize operstate with admin state on up/down

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CACGkMEtqRqj9hNki3TaCqAwUC9yY-kUYxmTKoM2b62D44PeDMA@mail.gmail.com>
Date: Mon, 27 May 2024 11:42:12 +0800
From: Jason Wang <jasowang@...hat.com>
To: Paolo Abeni <pabeni@...hat.com>
Cc: mst@...hat.com, xuanzhuo@...ux.alibaba.com, davem@...emloft.net, 
	edumazet@...gle.com, kuba@...nel.org, virtualization@...ts.linux.dev, 
	netdev@...r.kernel.org, Venkat Venkatsubra <venkat.x.venkatsubra@...cle.com>, 
	Gia-Khanh Nguyen <gia-khanh.nguyen@...cle.com>
Subject: Re: [PATCH net-next] virtio-net: synchronize operstate with admin
 state on up/down

On Tue, May 21, 2024 at 4:14 PM Paolo Abeni <pabeni@...hat.com> wrote:
>
> On Mon, 2024-05-20 at 09:03 +0800, Jason Wang wrote:
> > This patch synchronize operstate with admin state per RFC2863.
> >
> > This is done by trying to toggle the carrier upon open/close and
> > synchronize with the config change work. This allows propagate status
> > correctly to stacked devices like:
> >
> > ip link add link enp0s3 macvlan0 type macvlan
> > ip link set link enp0s3 down
> > ip link show
> >
> > Before this patch:
> >
> > 3: enp0s3: <BROADCAST,MULTICAST> mtu 1500 qdisc pfifo_fast state DOWN mode DEFAULT group default qlen 1000
> >     link/ether 00:00:05:00:00:09 brd ff:ff:ff:ff:ff:ff
> > ......
> > 5: macvlan0@...0s3: <BROADCAST,MULTICAST,UP,LOWER_UP,M-DOWN> mtu 1500 qdisc noqueue state UP mode DEFAULT group default qlen 1000
> >     link/ether b2:a9:c5:04:da:53 brd ff:ff:ff:ff:ff:ff
> >
> > After this patch:
> >
> > 3: enp0s3: <BROADCAST,MULTICAST> mtu 1500 qdisc pfifo_fast state DOWN mode DEFAULT group default qlen 1000
> >     link/ether 00:00:05:00:00:09 brd ff:ff:ff:ff:ff:ff
> > ...
> > 5: macvlan0@...0s3: <NO-CARRIER,BROADCAST,MULTICAST,UP,M-DOWN> mtu 1500 qdisc noqueue state LOWERLAYERDOWN mode DEFAULT group default qlen 1000
> >     link/ether b2:a9:c5:04:da:53 brd ff:ff:ff:ff:ff:ff
> >
> > Cc: Venkat Venkatsubra <venkat.x.venkatsubra@...cle.com>
> > Cc: Gia-Khanh Nguyen <gia-khanh.nguyen@...cle.com>
> > Signed-off-by: Jason Wang <jasowang@...hat.com>
>
> ## Form letter - net-next-closed
>
> The merge window for v6.10 has begun and we have already posted our
> pull
> request. Therefore net-next is closed for new drivers, features, code
> refactoring and optimizations. We are currently accepting bug fixes
> only.
>
> Please repost when net-next reopens after May 26th.

Will repost thanks.

>
> RFC patches sent for review only are obviously welcome at any time.
>
> See:
> https://www.kernel.org/doc/html/next/process/maintainer-netdev.html#development-cycle

Thanks for the pointer, I've done a short path by just looking at if
there's a patch with net-next posted in netdev :(

> --
> pw-bot: defer
>
>