netdev - Re: [PATCH][CFT][experimental] net/socket.c: use straight fdget/fdput (resend)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHk-=whMtdD37OJ7ABVuBi+JLkG+ZcuXf1+cwC=J+H5B3EASTg@mail.gmail.com>
Date: Mon, 27 May 2024 08:23:27 -0700
From: Linus Torvalds <torvalds@...ux-foundation.org>
To: Al Viro <viro@...iv.linux.org.uk>
Cc: netdev@...r.kernel.org, linux-fsdevel@...r.kernel.org
Subject: Re: [PATCH][CFT][experimental] net/socket.c: use straight fdget/fdput (resend)

On Sun, 26 May 2024 at 16:16, Al Viro <viro@...iv.linux.org.uk> wrote:
>
> FDPUT_FPUT is *not* a property of file; it's about the original
> reference to file not being guaranteed to stay pinned for the lifetime
> of struct fd in question...

Yup. I forgot the rules and thought we set FDPUT_PUT for cases where
we had exclusive access to 'struct file *', but it's for cases where
we have exclusive access to the 'int fd'.

               Linus