netdev - Re: [PATCH 3/4] net: ethernet: mlx4: remove unused struct 'mlx4_port

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <57520ee5-0d7d-40df-8edc-de85b1005453@gmail.com>
Date: Mon, 27 May 2024 08:29:51 +0300
From: Tariq Toukan <ttoukan.linux@...il.com>
To: linux@...blig.org, davem@...emloft.net, edumazet@...gle.com,
 kuba@...nel.org, pabeni@...hat.com
Cc: ionut@...ula.org, tariqt@...dia.com, netdev@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH 3/4] net: ethernet: mlx4: remove unused struct
 'mlx4_port_config'



On 26/05/2024 20:24, linux@...blig.org wrote:
> From: "Dr. David Alan Gilbert" <linux@...blig.org>
> 
> 'mlx4_port_config was added by
> commit ab9c17a009ee ("mlx4_core: Modify driver initialization flow to
> accommodate SRIOV for Ethernet")
> but remained unused.
> 
> Remove it.
> 
> Signed-off-by: Dr. David Alan Gilbert <linux@...blig.org>
> ---
>   drivers/net/ethernet/mellanox/mlx4/main.c | 6 ------
>   1 file changed, 6 deletions(-)
> 
> diff --git a/drivers/net/ethernet/mellanox/mlx4/main.c b/drivers/net/ethernet/mellanox/mlx4/main.c
> index 98688e4dbec5..febeadfdd5a5 100644
> --- a/drivers/net/ethernet/mellanox/mlx4/main.c
> +++ b/drivers/net/ethernet/mellanox/mlx4/main.c
> @@ -169,12 +169,6 @@ module_param_array(port_type_array, int, &arr_argc, 0444);
>   MODULE_PARM_DESC(port_type_array, "Array of port types: HW_DEFAULT (0) is default "
>   				"1 for IB, 2 for Ethernet");
>   
> -struct mlx4_port_config {
> -	struct list_head list;
> -	enum mlx4_port_type port_type[MLX4_MAX_PORTS + 1];
> -	struct pci_dev *pdev;
> -};
> -
>   static atomic_t pf_loading = ATOMIC_INIT(0);
>   
>   static int mlx4_devlink_ierr_reset_get(struct devlink *devlink, u32 id,

Reviewed-by: Tariq Toukan <tariqt@...dia.com>

Thanks for your patch.