netdev - Re: [PATCH net v2] enic: Validate length of nl attributes in enic_set_vf

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Mon, 27 May 2024 09:42:44 +0000
From: patchwork-bot+netdevbpf@...nel.org
To: Roded Zats <rzats@...oaltonetworks.com>
Cc: benve@...co.com, satishkh@...co.com, davem@...emloft.net,
 edumazet@...gle.com, kuba@...nel.org, pabeni@...hat.com,
 orcohen@...oaltonetworks.com, netdev@...r.kernel.org
Subject: Re: [PATCH net v2] enic: Validate length of nl attributes in
 enic_set_vf_port

Hello:

This patch was applied to netdev/net.git (main)
by Paolo Abeni <pabeni@...hat.com>:

On Wed, 22 May 2024 10:30:44 +0300 you wrote:
> enic_set_vf_port assumes that the nl attribute IFLA_PORT_PROFILE
> is of length PORT_PROFILE_MAX and that the nl attributes
> IFLA_PORT_INSTANCE_UUID, IFLA_PORT_HOST_UUID are of length PORT_UUID_MAX.
> These attributes are validated (in the function do_setlink in rtnetlink.c)
> using the nla_policy ifla_port_policy. The policy defines IFLA_PORT_PROFILE
> as NLA_STRING, IFLA_PORT_INSTANCE_UUID as NLA_BINARY and
> IFLA_PORT_HOST_UUID as NLA_STRING. That means that the length validation
> using the policy is for the max size of the attributes and not on exact
> size so the length of these attributes might be less than the sizes that
> enic_set_vf_port expects. This might cause an out of bands
> read access in the memcpys of the data of these
> attributes in enic_set_vf_port.
> 
> [...]

Here is the summary with links:
  - [net,v2] enic: Validate length of nl attributes in enic_set_vf_port
    https://git.kernel.org/netdev/net/c/e8021b94b041

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html