netdev - Re: [PATCH net v2] sock_map: avoid race between sock_map_close and sk_psock

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Tue, 28 May 2024 10:20:29 +0000
From: patchwork-bot+netdevbpf@...nel.org
To: Thadeu Lima de Souza Cascardo <cascardo@...lia.com>
Cc: netdev@...r.kernel.org, cong.wang@...edance.com, jakub@...udflare.com,
 edumazet@...gle.com, daniel@...earbox.net, john.fastabend@...il.com,
 davem@...emloft.net, kuba@...nel.org, ast@...nel.org, pabeni@...hat.com,
 bpf@...r.kernel.org, kernel-dev@...lia.com,
 syzbot+07a2e4a1a57118ef7355@...kaller.appspotmail.com, stable@...r.kernel.org
Subject: Re: [PATCH net v2] sock_map: avoid race between sock_map_close and
 sk_psock_put

Hello:

This patch was applied to netdev/net.git (main)
by Paolo Abeni <pabeni@...hat.com>:

On Fri, 24 May 2024 11:47:02 -0300 you wrote:
> sk_psock_get will return NULL if the refcount of psock has gone to 0, which
> will happen when the last call of sk_psock_put is done. However,
> sk_psock_drop may not have finished yet, so the close callback will still
> point to sock_map_close despite psock being NULL.
> 
> This can be reproduced with a thread deleting an element from the sock map,
> while the second one creates a socket, adds it to the map and closes it.
> 
> [...]

Here is the summary with links:
  - [net,v2] sock_map: avoid race between sock_map_close and sk_psock_put
    https://git.kernel.org/netdev/net/c/4b4647add7d3

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html