netdev - Re: [PATCH net-next v1 3/4] doc: netlink: Fix formatting of op flags in generated .rst

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZlXp5GMckD6NYnRl@gmail.com>
Date: Tue, 28 May 2024 07:27:48 -0700
From: Breno Leitao <leitao@...ian.org>
To: Donald Hunter <donald.hunter@...il.com>
Cc: netdev@...r.kernel.org, Jakub Kicinski <kuba@...nel.org>,
	"David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>, Paolo Abeni <pabeni@...hat.com>,
	Jiri Pirko <jiri@...nulli.us>,
	Arkadiusz Kubalewski <arkadiusz.kubalewski@...el.com>,
	Vadim Fedorenko <vadim.fedorenko@...ux.dev>,
	donald.hunter@...hat.com
Subject: Re: [PATCH net-next v1 3/4] doc: netlink: Fix formatting of op flags
 in generated .rst

On Tue, May 28, 2024 at 03:06:51PM +0100, Donald Hunter wrote:
> Generate op flags as an inline list instead of a stringified python
> value.
> 
> Signed-off-by: Donald Hunter <donald.hunter@...il.com>
> ---
>  tools/net/ynl/ynl-gen-rst.py | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/tools/net/ynl/ynl-gen-rst.py b/tools/net/ynl/ynl-gen-rst.py
> index 1096a71d7867..a957725b20dc 100755
> --- a/tools/net/ynl/ynl-gen-rst.py
> +++ b/tools/net/ynl/ynl-gen-rst.py
> @@ -172,7 +172,7 @@ def parse_do_attributes(attrs: Dict[str, Any], level: int = 0) -> str:
>  
>  def parse_operations(operations: List[Dict[str, Any]], namespace: str) -> str:
>      """Parse operations block"""
> -    preprocessed = ["name", "doc", "title", "do", "dump"]
> +    preprocessed = ["name", "doc", "title", "do", "dump", "flags"]
>      linkable = ["fixed-header", "attribute-set"]
>      lines = []
>  
> @@ -188,6 +188,8 @@ def parse_operations(operations: List[Dict[str, Any]], namespace: str) -> str:
>              if key in linkable:
>                  value = rst_ref(namespace, key, value)
>              lines.append(rst_fields(key, value, 0))
> +        if 'flags' in operation:

You probably want to use double quotes (") as the other cases ("do" and
"dump"). Other than that:

Reviwed-by: Breno Leitao <leitao@...ian.org>