netdev - Re: [PATCH net-next] ipv6: sr: restruct ifdefines

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ZlX4cLiUoMYzVdQG@hog>
Date: Tue, 28 May 2024 17:29:52 +0200
From: Sabrina Dubroca <sd@...asysnail.net>
To: Hangbin Liu <liuhangbin@...il.com>
Cc: netdev@...r.kernel.org, "David S. Miller" <davem@...emloft.net>,
	David Ahern <dsahern@...nel.org>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	Vasiliy Kovalev <kovalev@...linux.org>,
	Guillaume Nault <gnault@...hat.com>,
	Simon Horman <horms@...nel.org>,
	David Lebrun <david.lebrun@...ouvain.be>
Subject: Re: [PATCH net-next] ipv6: sr: restruct ifdefines

2024-05-28, 21:00:13 +0800, Hangbin Liu wrote:
> On Tue, May 28, 2024 at 12:05:12PM +0200, Sabrina Dubroca wrote:
> > Hi Hangbin,
> > 
> > 2024-05-28, 11:25:30 +0800, Hangbin Liu wrote:
> > > There are too many ifdef in IPv6 segment routing code that may cause logic
> > > problems. like commit 160e9d275218 ("ipv6: sr: fix invalid unregister error
> > > path"). To avoid this, the init functions are redefined for both cases. The
> > > code could be more clear after all fidefs are removed.
> > > 
> > > Signed-off-by: Hangbin Liu <liuhangbin@...il.com>
> > 
> > I think this was suggested by Simon?
> 
> Yes, and David Ahern also suggested this. And I thought you also mentioned it?

I don't think I did.

> I was afraid there are too many suggested-by tags here :) I can add them
> in next version patch.

Yes, please add tags for David and Simon.

Thanks!

-- 
Sabrina