netdev - Re: [PATCH net-next 5/5] net: stmmac: include linux/io.h rather than asm/io.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date: Tue, 28 May 2024 15:48:02 -0500
From: Andrew Halaney <ahalaney@...hat.com>
To: "Russell King (Oracle)" <rmk+kernel@...linux.org.uk>
Cc: Serge Semin <fancer.lancer@...il.com>, 
	Alexandre Torgue <alexandre.torgue@...s.st.com>, Jose Abreu <joabreu@...opsys.com>, 
	"David S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, 
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, 
	Maxime Coquelin <mcoquelin.stm32@...il.com>, netdev@...r.kernel.org, linux-stm32@...md-mailman.stormreply.com, 
	linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH net-next 5/5] net: stmmac: include linux/io.h rather than
 asm/io.h

On Tue, May 28, 2024 at 12:48:58PM GMT, Russell King (Oracle) wrote:
> Include linux/io.h instead of asm/io.h since linux/ includes are
> preferred.
> 
> Signed-off-by: Russell King (Oracle) <rmk+kernel@...linux.org.uk>

Reviewed-by: Andrew Halaney <ahalaney@...hat.com>

> ---
>  drivers/net/ethernet/stmicro/stmmac/dwmac1000_core.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac1000_core.c b/drivers/net/ethernet/stmicro/stmmac/dwmac1000_core.c
> index d0c7c2320d8d..d413d76a8936 100644
> --- a/drivers/net/ethernet/stmicro/stmmac/dwmac1000_core.c
> +++ b/drivers/net/ethernet/stmicro/stmmac/dwmac1000_core.c

Any reason you didn't wanna treat the other examples of this similarly?

    ahalaney@...en2nano ~/git/linux-next (git)-[tags/next-20240528] % git grep "asm/io.h" drivers/net/ethernet/stmicro/stmmac/
    drivers/net/ethernet/stmicro/stmmac/dwmac1000_core.c:#include <asm/io.h>
    drivers/net/ethernet/stmicro/stmmac/dwmac1000_dma.c:#include <asm/io.h>
    drivers/net/ethernet/stmicro/stmmac/dwmac100_core.c:#include <asm/io.h>
    drivers/net/ethernet/stmicro/stmmac/dwmac100_dma.c:#include <asm/io.h>
    drivers/net/ethernet/stmicro/stmmac/stmmac_ethtool.c:#include <asm/io.h>
    ahalaney@...en2nano ~/git/linux-next (git)-[tags/next-20240528] % 

Thanks for the series,
Andrew

> @@ -15,7 +15,7 @@
>  #include <linux/crc32.h>
>  #include <linux/slab.h>
>  #include <linux/ethtool.h>
> -#include <asm/io.h>
> +#include <linux/io.h>
>  #include "stmmac.h"
>  #include "stmmac_pcs.h"
>  #include "dwmac1000.h"
> -- 
> 2.30.2
>