netdev - RE: [PATCH net-next] r8169: disable interrupt source RxOverflow

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Tue, 28 May 2024 06:15:51 +0000
From: Sunil Kovvuri Goutham <sgoutham@...vell.com>
To: Heiner Kallweit <hkallweit1@...il.com>, Paolo Abeni <pabeni@...hat.com>,
        Jakub Kicinski <kuba@...nel.org>, David Miller <davem@...emloft.net>,
        Eric
 Dumazet <edumazet@...gle.com>,
        Realtek linux nic maintainers
	<nic_swsd@...ltek.com>
CC: "netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: RE: [PATCH net-next] r8169: disable interrupt source RxOverflow



> -----Original Message-----
> From: Heiner Kallweit <hkallweit1@...il.com>
> Sent: Tuesday, May 28, 2024 12:47 AM
> To: Paolo Abeni <pabeni@...hat.com>; Jakub Kicinski <kuba@...nel.org>;
> David Miller <davem@...emloft.net>; Eric Dumazet
> <edumazet@...gle.com>; Realtek linux nic maintainers
> <nic_swsd@...ltek.com>
> Cc: netdev@...r.kernel.org
> Subject: [PATCH net-next] r8169: disable interrupt source
> RxOverflow
> 
> Vendor driver calls this bit RxDescUnavail. All we do in the interrupt handler in
> this case is scheduling NAPI. If we should be out of RX descriptors, then NAPI
> is scheduled anyway. Therefore remove this interrupt source. Tested on
> RTL8168h.
> 
> Signed-off-by: Heiner Kallweit <hkallweit1@...il.com>
> ---
>  drivers/net/ethernet/realtek/r8169_main.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/drivers/net/ethernet/realtek/r8169_main.c
> b/drivers/net/ethernet/realtek/r8169_main.c
> index e8f90a8fa..e9f5185e4 100644
> --- a/drivers/net/ethernet/realtek/r8169_main.c
> +++ b/drivers/net/ethernet/realtek/r8169_main.c
> @@ -5085,12 +5085,10 @@ static void rtl_set_irq_mask(struct
> rtl8169_private *tp)
>  	tp->irq_mask = RxOK | RxErr | TxOK | TxErr | LinkChg;
> 
>  	if (tp->mac_version <= RTL_GIGA_MAC_VER_06)
> -		tp->irq_mask |= SYSErr | RxOverflow | RxFIFOOver;
> +		tp->irq_mask |= SYSErr | RxFIFOOver;
>  	else if (tp->mac_version == RTL_GIGA_MAC_VER_11)
>  		/* special workaround needed */
>  		tp->irq_mask |= RxFIFOOver;
> -	else
> -		tp->irq_mask |= RxOverflow;
>  }
> 
>  static int rtl_alloc_irq(struct rtl8169_private *tp)
> --
> 2.45.1
> 

LGTM
Reviewed-by: Sunil Goutham <sgoutham@...vell.com>