netdev - Re: [PATCH net] netdev: add qstat for csum complete

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZldytYTJEU8yAJqA@LQ3V64L9R2>
Date: Wed, 29 May 2024 11:23:49 -0700
From: Joe Damato <jdamato@...tly.com>
To: Jakub Kicinski <kuba@...nel.org>
Cc: davem@...emloft.net, netdev@...r.kernel.org, edumazet@...gle.com,
	pabeni@...hat.com, donald.hunter@...il.com, sdf@...gle.com,
	amritha.nambiar@...el.com, hawk@...nel.org,
	sridhar.samudrala@...el.com
Subject: Re: [PATCH net] netdev: add qstat for csum complete

On Wed, May 29, 2024 at 09:35:47AM -0700, Jakub Kicinski wrote:
> Recent commit 0cfe71f45f42 ("netdev: add queue stats") added
> a lot of useful stats, but only those immediately needed by virtio.
> Presumably virtio does not support CHECKSUM_COMPLETE,
> so statistic for that form of checksumming wasn't included.
> Other drivers will definitely need it, in fact we expect it
> to be needed in net-next soon (mlx5). So let's add the definition
> of the counter for CHECKSUM_COMPLETE to uAPI in net already,
> so that the counters are in a more natural order (all subsequent
> counters have not been present in any released kernel, yet).

As you mentioned, the counters are not in any released kernel yet,
so adding it to the uAPI makes sense to me.

Are you planning to submit a separate change to add csum_complete to
struct netdev_queue_stats_rx, as well? Just wanted to double check,
but I assume that is a net-next thing.

Reviewed-by: Joe Damato <jdamato@...tly.com>