netdev - Re: [syzbot] [net?] INFO: rcu detected stall in packet

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20240529225214.2968-1-hdanton@sina.com>
Date: Thu, 30 May 2024 06:52:14 +0800
From: Hillf Danton <hdanton@...a.com>
To: syzbot <syzbot+a7d2b1d5d1af83035567@...kaller.appspotmail.com>
Cc: linux-kernel@...r.kernel.org,
	netdev@...r.kernel.org,
	syzkaller-bugs@...glegroups.com,
	Vladimir Oltean <vladimir.oltean@....com>,
	Radoslaw Zielonek <radoslaw.zielonek@...il.com>,
	Vinicius Costa Gomes <vinicius.gomes@...el.com>,
	Eric Dumazet <edumazet@...gle.com>
Subject: Re: [syzbot] [net?] INFO: rcu detected stall in packet_release

Test Vlad's patch [1]
[1] https://lore.kernel.org/netdev/20240527153955.553333-1-vladimir.oltean@nxp.com/

#syz test https://git.kernel.org/pub/scm/linux/kernel/git/netdev/net-next.git  main

--- x/net/sched/sch_taprio.c
+++ y/net/sched/sch_taprio.c
@@ -1847,6 +1847,7 @@ static int taprio_change(struct Qdisc *s
 		return -EOPNOTSUPP;
 	}
 	q->flags = taprio_flags;
+	taprio_set_picos_per_byte(dev, q);
 
 	err = taprio_parse_mqprio_opt(dev, mqprio, extack, q->flags);
 	if (err < 0)
@@ -1907,7 +1908,6 @@ static int taprio_change(struct Qdisc *s
 	if (err < 0)
 		goto free_sched;
 
-	taprio_set_picos_per_byte(dev, q);
 	taprio_update_queue_max_sdu(q, new_admin, stab);
 
 	if (FULL_OFFLOAD_IS_ENABLED(q->flags))
--