netdev - Re: [PATCH net-next v2 5/7] ionic: Use netdev_name() function instead of netdev->name

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAH-L+nPQ016BqhbdwECL+GRT3OJGW2vmzg9wU1MT3_Swd_OPjw@mail.gmail.com>
Date: Wed, 29 May 2024 11:00:58 +0530
From: Kalesh Anakkur Purayil <kalesh-anakkur.purayil@...adcom.com>
To: Shannon Nelson <shannon.nelson@....com>
Cc: netdev@...r.kernel.org, davem@...emloft.net, kuba@...nel.org, 
	edumazet@...gle.com, pabeni@...hat.com, horms@...nel.org, 
	brett.creeley@....com, drivers@...sando.io
Subject: Re: [PATCH net-next v2 5/7] ionic: Use netdev_name() function instead
 of netdev->name

On Wed, May 29, 2024 at 5:34 AM Shannon Nelson <shannon.nelson@....com> wrote:
>
> From: Brett Creeley <brett.creeley@....com>
>
> There is no reason not to use netdev_name() in these places, so do just
> as the title states.
>
> Signed-off-by: Brett Creeley <brett.creeley@....com>
> Signed-off-by: Shannon Nelson <shannon.nelson@....com>

Looks good to me.

Reviewed-by: Kalesh AP <kalesh-anakkur.purayil@...adcom.com>
> ---
>  drivers/net/ethernet/pensando/ionic/ionic_debugfs.c | 2 +-
>  drivers/net/ethernet/pensando/ionic/ionic_lif.c     | 4 ++--
>  2 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/net/ethernet/pensando/ionic/ionic_debugfs.c b/drivers/net/ethernet/pensando/ionic/ionic_debugfs.c
> index c3ae11a48024..59e5a9f21105 100644
> --- a/drivers/net/ethernet/pensando/ionic/ionic_debugfs.c
> +++ b/drivers/net/ethernet/pensando/ionic/ionic_debugfs.c
> @@ -220,7 +220,7 @@ static int netdev_show(struct seq_file *seq, void *v)
>  {
>         struct net_device *netdev = seq->private;
>
> -       seq_printf(seq, "%s\n", netdev->name);
> +       seq_printf(seq, "%s\n", netdev_name(netdev));
>
>         return 0;
>  }
> diff --git a/drivers/net/ethernet/pensando/ionic/ionic_lif.c b/drivers/net/ethernet/pensando/ionic/ionic_lif.c
> index 101cbc088853..23e1f6638b38 100644
> --- a/drivers/net/ethernet/pensando/ionic/ionic_lif.c
> +++ b/drivers/net/ethernet/pensando/ionic/ionic_lif.c
> @@ -237,7 +237,7 @@ static int ionic_request_irq(struct ionic_lif *lif, struct ionic_qcq *qcq)
>         const char *name;
>
>         if (lif->registered)
> -               name = lif->netdev->name;
> +               name = netdev_name(lif->netdev);
>         else
>                 name = dev_name(dev);
>
> @@ -3732,7 +3732,7 @@ static void ionic_lif_set_netdev_info(struct ionic_lif *lif)
>                 },
>         };
>
> -       strscpy(ctx.cmd.lif_setattr.name, lif->netdev->name,
> +       strscpy(ctx.cmd.lif_setattr.name, netdev_name(lif->netdev),
>                 sizeof(ctx.cmd.lif_setattr.name));
>
>         ionic_adminq_post_wait(lif, &ctx);
> --
> 2.17.1
>
>


-- 
Regards,
Kalesh A P

Download attachment "smime.p7s" of type "application/pkcs7-signature" (4239 bytes)