netdev - Re: [PATCH net-next v13 12/14] net: ptp: Move ptp_clock

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240530145350.6341746f@kmaincent-XPS-13-7390>
Date: Thu, 30 May 2024 14:53:50 +0200
From: Kory Maincent <kory.maincent@...tlin.com>
To: Sai Krishna Gajula <saikrishnag@...vell.com>
Cc: Florian Fainelli <florian.fainelli@...adcom.com>, Broadcom internal
 kernel review list <bcm-kernel-feedback-list@...adcom.com>, Andrew Lunn
 <andrew@...n.ch>, Heiner Kallweit <hkallweit1@...il.com>, Russell King
 <linux@...linux.org.uk>, "David S. Miller" <davem@...emloft.net>, Eric
 Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>, Paolo
 Abeni <pabeni@...hat.com>, Richard Cochran <richardcochran@...il.com>, Radu
 Pirea <radu-nicolae.pirea@....nxp.com>, Jay Vosburgh
 <j.vosburgh@...il.com>, Andy Gospodarek <andy@...yhouse.net>, Nicolas Ferre
 <nicolas.ferre@...rochip.com>, Claudiu Beznea <claudiu.beznea@...on.dev>,
 Willem de Bruijn <willemdebruijn.kernel@...il.com>, Jonathan Corbet
 <corbet@....net>, Horatiu Vultur <horatiu.vultur@...rochip.com>,
 "UNGLinuxDriver@...rochip.com" <UNGLinuxDriver@...rochip.com>, Simon Horman
 <horms@...nel.org>, Vladimir Oltean <vladimir.oltean@....com>, Thomas
 Petazzoni <thomas.petazzoni@...tlin.com>, "netdev@...r.kernel.org"
 <netdev@...r.kernel.org>, "linux-kernel@...r.kernel.org"
 <linux-kernel@...r.kernel.org>, "linux-doc@...r.kernel.org"
 <linux-doc@...r.kernel.org>, Maxime Chevallier
 <maxime.chevallier@...tlin.com>, Rahul Rameshbabu <rrameshbabu@...dia.com>
Subject: Re:  [PATCH net-next v13 12/14] net: ptp: Move ptp_clock_index() to
 builtin symbol

Hello Sai,

On Thu, 30 May 2024 11:23:10 +0000
Sai Krishna Gajula <saikrishnag@...vell.com> wrote:

> > Move ptp_clock_index() to builtin symbols to prepare for supporting get and
> > set hardware timestamps from ethtool, which is builtin.
> > 
> > Signed-off-by: Kory Maincent <kory.maincent@...tlin.com>

> >  }
> > +
> > +int ptp_clock_index(struct ptp_clock *ptp) {
> > +	return ptp->index;
> > +}
> > +EXPORT_SYMBOL(ptp_clock_index);
> >   
> Please check the "build_clang - FAILED", "build_32bit - FAILED" build errors.

Could you be more explicit? Which config are you using?
What is the build error?

I don't really see how this patch can bring a 32bit or clang build error. 

Regards,
-- 
Köry Maincent, Bootlin
Embedded Linux and kernel engineering
https://bootlin.com