netdev - Re: [PATCH v2 2/3] mctp pcc: Allow PCC Data Type in MCTP resource.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <75d4b180-206e-4d48-9506-f0f602b46eca@amperemail.onmicrosoft.com>
Date: Thu, 30 May 2024 12:24:53 -0400
From: Adam Young <admiyo@...eremail.onmicrosoft.com>
To: Ratheesh Kannoth <rkannoth@...vell.com>, admiyo@...amperecomputing.com
Cc: Robert Moore <robert.moore@...el.com>,
 "Rafael J. Wysocki" <rafael.j.wysocki@...el.com>, Len Brown
 <lenb@...nel.org>, netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 2/3] mctp pcc: Allow PCC Data Type in MCTP resource.

On 5/28/24 23:25, Ratheesh Kannoth wrote:
> On 2024-05-29 at 00:48:22, admiyo@...amperecomputing.com (admiyo@...amperecomputing.com) wrote:
>> From: Adam Young <admiyo@...erecomputing.com>
>> --- a/drivers/acpi/acpica/rsaddr.c
>> +++ b/drivers/acpi/acpica/rsaddr.c
>> @@ -282,7 +282,7 @@ acpi_rs_get_address_common(struct acpi_resource *resource,
>>
>>   	/* Validate the Resource Type */
>>
>> -	if ((address.resource_type > 2) && (address.resource_type < 0xC0)) {
>> +	if ((address.resource_type > 2) && (address.resource_type < 0xC0) && (address.resource_type != 10)) {
> use macros or enums instead of hard coded numbers. That will improve code readability.

In general I agree, but this code is generated  from ACPICA and will not 
be directly commited.  The corresponding patch to acpica has already 
merged. What you see here is what the code will look like post-process 
from ACPICA conversion.

>
>>   		return (FALSE);
>>   	}
>>
>> --
>> 2.34.1
>>