[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <21903032-f845-416b-8be7-646d36c50f59@intel.com>
Date: Thu, 30 May 2024 09:50:41 -0700
From: Jacob Keller <jacob.e.keller@...el.com>
To: Jakub Kicinski <kuba@...nel.org>, Wojciech Drewek
<wojciech.drewek@...el.com>
CC: David Miller <davem@...emloft.net>, netdev <netdev@...r.kernel.org>,
Wojciech Drewek <wojciech.drewek@...el.com>, Michal Swiatkowski
<michal.swiatkowski@...ux.intel.com>, Brett Creeley <brett.creeley@....com>,
Pucha Himasekhar Reddy <himasekharx.reddy.pucha@...el.com>
Subject: Re: [PATCH net 6/8] ice: implement AQ download pkg retry
On 5/29/2024 6:51 PM, Jakub Kicinski wrote:
> On Tue, 28 May 2024 15:06:09 -0700 Jacob Keller wrote:
>> + while (try_cnt < 5) {
>> + status = ice_aq_download_pkg(hw, bh, ICE_PKG_BUF_SIZE,
>> + last, &offset, &info,
>> + NULL);
>> + if (hw->adminq.sq_last_status != ICE_AQ_RC_ENOSEC &&
>> + hw->adminq.sq_last_status != ICE_AQ_RC_EBADSIG)
>> + break;
>> +
>> + try_cnt++;
>> + msleep(20);
>> + }
>> +
>> + if (try_cnt)
>> + dev_dbg(ice_hw_to_dev(hw),
>> + "ice_aq_download_pkg number of retries: %d\n",
>> + try_cnt);
>>
>
> That's not a great wait loop. Last iteration sleeps for 20msec and then
> gives up without checking the condition.
Yea, that seems rather silly.
@Wojciech, would you please look into this?
Powered by blists - more mailing lists