netdev - Re: [PATCH net-next 11/15] net/mlx5e: SHAMPO, Add no-split ethtool counters for header/data split

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZlfzR_UV9CcCjR99@x130.lan>
Date: Wed, 29 May 2024 20:32:23 -0700
From: Saeed Mahameed <saeed@...nel.org>
To: Jakub Kicinski <kuba@...nel.org>
Cc: Tariq Toukan <tariqt@...dia.com>,
	"David S. Miller" <davem@...emloft.net>,
	Paolo Abeni <pabeni@...hat.com>, Eric Dumazet <edumazet@...gle.com>,
	netdev@...r.kernel.org, Saeed Mahameed <saeedm@...dia.com>,
	Gal Pressman <gal@...dia.com>, Leon Romanovsky <leonro@...dia.com>,
	Dragos Tatulea <dtatulea@...dia.com>
Subject: Re: [PATCH net-next 11/15] net/mlx5e: SHAMPO, Add no-split ethtool
 counters for header/data split

On 29 May 18:22, Jakub Kicinski wrote:
>On Tue, 28 May 2024 17:28:03 +0300 Tariq Toukan wrote:
>> +   * - `rx[i]_hds_nosplit_packets`
>> +     - Number of packets that were not split in modes that do header/data split
>> +       [#accel]_.
>> +     - Informative
>> +
>> +   * - `rx[i]_hds_nosplit_bytes`
>> +     - Number of bytes that were not split in modes that do header/data split
>> +       [#accel]_.
>> +     - Informative
>
>This is too vague. The ethtool HDS feature is for TCP only.
>What does this count? Non-TCP packets basically?
>

But this is not the ethtool HDS, this is the mlx5 HW GRO hds.
On the sane note, are we planning to have different control knobs/stats for
tcp/udp/ip HDS? ConnectX supports both TCP and UDP on the same queue, 
the driver has no control on which protocol gets HDS and which doesn't.

>Given this is a HW-GRO series, are HDS packets == HW-GRO eligible
>packets?
>

No, UDP will also get header data split or other TCP packets that don't
belong to any aggregation context in the HW.